Use `Writable` utility type to improve typings by JeanMeche · Pull Request #49754 · angular/angular

JeanMeche · 2023-04-08T23:30:03Z

The Writable type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of any or {myPrivateKey: any} type assertions for example.

See individual commits

PR Type

What kind of change does this PR introduce?

Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

No

JeanMeche · 2023-04-08T23:40:46Z

Any idea why this property is of type true and not a boolean ?

JeanMeche · 2023-04-21T12:29:21Z

No interest for this change ? =)

dylhunn · 2023-04-24T18:55:50Z

This is a nice change conceptually. I just need to sit down and look over all the usage points.

JeanMeche · 2023-04-25T14:26:32Z

@dylhunn Should be really straight forward 😊

JeanMeche · 2023-07-03T13:32:01Z

The presubmit is failing, any info on what is breaking ?

jessicajaniuk

reviewed-for: fw-animations

dylhunn

reviewed-for: fw-core, fw-forms

The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertion for example.

…operties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example.

…perties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example.

…roperties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example.

…eadonly properties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example.

…ly properties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of type assertions.

dylhunn · 2023-09-22T16:58:06Z

g3 presubmit is passing.

dylhunn · 2023-09-22T17:01:20Z

disabling pullapprove -- router change is a no-op

dylhunn · 2023-09-22T17:02:17Z

This PR was merged into the repository by commit e5d327d.

…operties. (#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example. PR Close #49754

…perties. (#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example. PR Close #49754

…roperties. (#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example. PR Close #49754

…eadonly properties. (#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example. PR Close #49754

…ly properties. (#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of type assertions. PR Close #49754

angular-automatic-lock-bot · 2023-10-23T00:09:21Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertion for example. PR Close angular#49754

…operties. (angular#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example. PR Close angular#49754

…perties. (angular#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example. PR Close angular#49754

…roperties. (angular#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example. PR Close angular#49754

…eadonly properties. (angular#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example. PR Close angular#49754

…ly properties. (angular#49754) The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of type assertions. PR Close angular#49754

JeanMeche commented Apr 8, 2023

View reviewed changes

Comment thread packages/forms/src/directives/ng_control_status.ts Outdated

JeanMeche force-pushed the chore/use-writable branch from 19a94b6 to d390fdd Compare April 8, 2023 23:34

JeanMeche commented Apr 8, 2023

View reviewed changes

JeanMeche force-pushed the chore/use-writable branch from d390fdd to 0b65882 Compare April 8, 2023 23:54

JeanMeche marked this pull request as ready for review April 9, 2023 00:05

pullapprove Bot requested review from atscott, dylhunn and jessicajaniuk April 9, 2023 00:06

JeanMeche force-pushed the chore/use-writable branch 5 times, most recently from 6d3600c to dd6fba6 Compare April 11, 2023 18:30

jessicajaniuk added the area: core Issues related to the framework runtime label Apr 12, 2023

ngbot Bot added this to the Backlog milestone Apr 12, 2023

pullapprove Bot removed the request for review from atscott May 4, 2023 02:25

pullapprove Bot requested a review from AndrewKushnir May 16, 2023 09:27

JeanMeche mentioned this pull request Jun 6, 2023

refactor(core): handle #24571 todos. #49221

Closed

JeanMeche force-pushed the chore/use-writable branch from dd6fba6 to 3c1cee5 Compare June 27, 2023 21:30

JeanMeche force-pushed the chore/use-writable branch 2 times, most recently from 06fffe3 to b8d71f6 Compare August 29, 2023 17:54

jessicajaniuk approved these changes Aug 31, 2023

View reviewed changes

dylhunn approved these changes Sep 19, 2023

View reviewed changes

JeanMeche added 3 commits September 19, 2023 19:08

refactor(core): Private export of the Writable type

39ec5d1

The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertion for example.

refactor(forms): Use the Writable type when overwriting readonly pr…

32de4e4

…operties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example.

refactor(core): Use the Writable type when overwriting readonly pro…

cbb0a3c

…perties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example.

JeanMeche added 3 commits September 19, 2023 19:13

refactor(router): Use the Writable type when overwriting readonly p…

830467f

…roperties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of `any` type assertions for example.

refactor(animations): Use the Writable type when overwriting readon…

2da5233

…ly properties. The `Writable` type is usefull when we want overwrite readonly properties and we still want to maintain code navigation/reference. It should be use instead of type assertions.

JeanMeche force-pushed the chore/use-writable branch from 3226227 to 2da5233 Compare September 19, 2023 17:13

dylhunn removed the request for review from AndrewKushnir September 22, 2023 16:57

dylhunn added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Sep 22, 2023

pullapprove Bot requested a review from atscott September 22, 2023 16:58

dylhunn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable labels Sep 22, 2023

dylhunn removed the request for review from atscott September 22, 2023 17:01

dylhunn closed this in ca416b5 Sep 22, 2023

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 23, 2023

JeanMeche deleted the chore/use-writable branch February 29, 2024 13:39

Navigation Menu

Repository navigation

Use `Writable` utility type to improve typings - #49754

Use `Writable` utility type to improve typings#49754
JeanMeche wants to merge 6 commits into
angular:mainfrom
JeanMeche:chore/use-writable

JeanMeche commented Apr 8, 2023 •

edited

Loading

Uh oh!

Uh oh!

JeanMeche Apr 8, 2023

Uh oh!

JeanMeche commented Apr 21, 2023

Uh oh!

dylhunn commented Apr 24, 2023

Uh oh!

JeanMeche commented Apr 25, 2023

Uh oh!

JeanMeche commented Jul 3, 2023

Uh oh!

jessicajaniuk left a comment

Uh oh!

dylhunn left a comment

Uh oh!

dylhunn commented Sep 22, 2023

Uh oh!

dylhunn commented Sep 22, 2023

Uh oh!

dylhunn commented Sep 22, 2023

Uh oh!

angular-automatic-lock-bot Bot commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

JeanMeche commented Apr 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Does this PR introduce a breaking change?

Uh oh!

Uh oh!

JeanMeche Apr 8, 2023

Choose a reason for hiding this comment

Uh oh!

JeanMeche commented Apr 21, 2023

Uh oh!

dylhunn commented Apr 24, 2023

Uh oh!

JeanMeche commented Apr 25, 2023

Uh oh!

JeanMeche commented Jul 3, 2023

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

dylhunn left a comment

Choose a reason for hiding this comment

Uh oh!

dylhunn commented Sep 22, 2023

Uh oh!

dylhunn commented Sep 22, 2023

Uh oh!

dylhunn commented Sep 22, 2023

Uh oh!

angular-automatic-lock-bot Bot commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JeanMeche commented Apr 8, 2023 •

edited

Loading