Repository navigation
Add import error to deactivated dag - #65687
Merged
bbovenzi merged 7 commits intoJun 10, 2026
Merged
Conversation
bbovenzi
requested review from
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
April 22, 2026 18:14
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Thanks, looks cool.
A few suggestions
bbovenzi
force-pushed
the
add-import-error-to-deactivated-dag
branch
from
May 5, 2026 20:02
65d6d59 to
55c7ed3
Compare
bbovenzi
requested review from
bugraoz93,
ephraimbuddy,
jason810496 and
rawwar
as code owners
May 5, 2026 20:02
parkhojeong
reviewed
May 7, 2026
bbovenzi
force-pushed
the
add-import-error-to-deactivated-dag
branch
from
May 13, 2026 15:39
55c7ed3 to
6c072e5
Compare
bbovenzi
force-pushed
the
add-import-error-to-deactivated-dag
branch
from
May 13, 2026 18:56
d944902 to
e766863
Compare
Contributor
Author
|
A bunch of updates. I refactored the whole thing to be a banner on the HeaderCard that will display on any Dag related header |
parkhojeong
reviewed
May 15, 2026
parkhojeong
left a comment
parkhojeong
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good overall.
I left one comment about multi-bundle import error matching.
bbovenzi
force-pushed
the
add-import-error-to-deactivated-dag
branch
from
June 2, 2026 19:48
9bb9a9a to
52f1848
Compare
jscheffl
approved these changes
Jun 7, 2026
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Cool from my side! Definitely helps fiding errors more quickly.
Just one UX question: Why not using the same Banner we have for Backfill and in general for this? Would be a bit more consistent.
Contributor
Author
I want to redo that banner to be honest. |
bbovenzi
force-pushed
the
add-import-error-to-deactivated-dag
branch
from
June 8, 2026 15:04
52f1848 to
194bd6f
Compare
pierrejeambrun
approved these changes
Jun 8, 2026
bbovenzi
force-pushed
the
add-import-error-to-deactivated-dag
branch
2 times, most recently
from
June 9, 2026 21:09
f7a0f9e to
59c883f
Compare
# This is the 1st commit message: Add import error to dag page when deactivated # This is the commit message #2: Move to modal
bbovenzi
force-pushed
the
add-import-error-to-deactivated-dag
branch
from
June 10, 2026 16:12
59c883f to
1a21010
Compare
dingo4dev
pushed a commit
to dingo4dev/airflow
that referenced
this pull request
Jun 16, 2026
* # This is a combination of 2 commits. # This is the 1st commit message: Add import error to dag page when deactivated # This is the commit message apache#2: Move to modal * Add import error to dag page when deactivated * Change badge to a banner * Fix test * Cleanup banner code * Add bundleName param * Fix CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dag is stale, check for import errors and display any.
I switched this to a banner in the HeaderCard instead of in the dag breadcrumb. Helps handle deactivated dags and if they have any import errors.
Related #56250
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.