Repository navigation
Add unit tests for the Dataprep links - #72955
ShousenZHANG wants to merge 1 commit into
Conversation
`providers/google/tests/unit/google/cloud/links/test_dataprep.py` was listed in `OVERLOOKED_TESTS`, so `DataprepFlowLink` and `DataprepJobGroupLink` had no coverage. Adds class-attribute and `persist` checks for both, plus a `_format_link` case that pins the behaviour specific to this module: Dataprep defines its own absolute `BASE_LINK` (`https://clouddataprep.com`), so `_format_link` returns the formatted string as-is rather than prefixing the Google Cloud console `BASE_LINK` the way the other link modules do. Drops the path from `OVERLOOKED_TESTS`. related: #35442 Generated-by: Claude Code
boring-cyborg
Bot
added
area:providers
provider:google
|
Closing this along with the other 19 PRs opened from this account today. These are the first 20 PRs from this account, and 17 of them were opened inside a two-minute window, between 14:59:50Z and 15:01:43Z, about seven seconds apart. Each carries Airflow is maintained by volunteers, so every PR costs reviewer time and CI capacity. |
kaxil
added
AI Spam
closed because of multiple quality violations
|
Also, one PR per module is the wrong unit: twenty PRs for one logical change is twenty reviews and twenty CI runs, when it should have been a single PR. The tests add little on their own merits either, since |
providers/google/tests/unit/google/cloud/links/test_dataprep.pywas listed inOVERLOOKED_TESTS, soDataprepFlowLinkandDataprepJobGroupLinkhad no coverage.Adds class-attribute and
persistchecks for both, plus a_format_linkcase that pins a behaviour specific to this module:Dataprep defines its own absolute
BASE_LINK(https://clouddataprep.com), unlike the other link modules which build relative paths on top oflinks/base.py's Google Cloud consoleBASE_LINK.BaseGoogleLink._format_linkbranches onformatted_str.startswith("http"), so Dataprep links are returned as-is with no console prefix. The test asserts exactly that, which is the part a future refactor of_format_linkcould silently break.The
OVERLOOKED_TESTSentry is removed in this PR.Follows the same shape as #72949 (
test_bigquery_dts.py).related: #35442
Was generative AI tooling used to co-author this PR?
Generated-by: Claude CodeThe test bodies were written by an AI assistant following the existing
test_bigquery.pypattern in the same directory. I verified them myself:pytest providers/google/tests/unit/google/cloud/links/test_dataprep.py— 6 passedpytest airflow-core/tests/unit/always/test_project_structure.py— 10 passed, 1 pre-existing xfailprek run --files <both files>— 43 passed, 212 skipped, 0 failed