Add missing test modules in our unit test suite

cc: @ephraimbuddy -> this might guide people on where to add tests to cover whole modules that are not "targeted" for tests (they might still be accidentally tested by other modules but they do not have dedicated module tests) - this might help people to make decision on where to add some tests. Also this is a nice list of "todos"

Add mising common.io test_file_transfer.py (#35457)

tests/providers/slack/notifications/test_slack_notifier.py

I think how to exclude case when the original module airflow.providers.slack.notifications.slack_notifier is deprecated

And just add here previous investigation about missing tests #28459 (comment), non all of them actually missing:

some of tests moved into tests.integrations

Amazon links tested in one go in same module

Some of amazon tests split across different test modules, for example: test_s3_bucket.py + test_s3_bucket_tagging.py + test_s3_file_transform.py + test_s3_list.py + test_s3_list_prefixes.py + test_s3_object.py but module named as s3.py (merged version)

And codecov statistic also might help to found untested parts: https://app.codecov.io/gh/apache/airflow/tree/main/airflow%2Fproviders

tests/providers/slack/notifications/test_slack_notifier.py

I think how to exclude case when the original module airflow.providers.slack.notifications.slack_notifier is deprecated

In similar cases we used to have deprecated classes list and we removed it from the output

Add missing unit tests for the Celery default configuration builder

Add missing unit tests for common.compat lineage entities (#72506)

Picking up the missing test module for the common-messaging provider base class:

providers/common/messaging/tests/unit/common/messaging/providers/test_base_provider.py

Checked for existing claims and open PRs covering this path first — none found. Will remove the corresponding entry from OVERLOOKED_TESTS in the same PR.

Drafted-by: Claude Code (Fable 5) (no human review before posting)

Add tests for the AWS Batch executor boto schemas (apache#72609)

Add missing unit tests for common.compat lineage entities (apache#72506)

Taking providers/google/tests/unit/google/cloud/links/test_bigquery_dts.py.

It covers one class, BigQueryDataTransferConfigLink, and follows the three checks the sibling link tests already use — class attributes, the persist XCom payload, and _format_link against BASE_LINK (same shape as test_bigquery.py from #68066).

The OVERLOOKED_TESTS entry goes in the same PR.

No overlap with test_cloud_tasks.py (#72846). If this shape is acceptable I'd like to keep working through the other google/cloud/links/ entries — there are 19 left after that one.

Add missing unit tests for the common-messaging provider base class (#…

Following up on my earlier comment: I have gone through the rest of the
providers/google/tests/unit/google/cloud/links/ entries in the list. Posting the full set
here so nobody duplicates the work. Each PR adds one test module and removes only its own
OVERLOOKED_TESTS line.

module	PR
`test_bigquery_dts.py`	#72949
`test_dataprep.py`	#72955
`test_datastore.py`	#72956
`test_bigtable.py`	#72960
`test_cloud_build.py`	#72961
`test_cloud_functions.py`	#72962
`test_cloud_memorystore.py`	#72963
`test_cloud_sql.py`	#72964
`test_compute.py`	#72965
`test_data_loss_prevention.py`	#72966
`test_dataflow.py`	#72967
`test_dataform.py`	#72968
`test_datafusion.py`	#72969
`test_dataproc.py`	#72970
`test_kubernetes_engine.py`	#72971
`test_pubsub.py`	#72972
`test_spanner.py`	#72973
`test_stackdriver.py`	#72974
`test_translate.py`	#72975
`test_workflows.py`	#72976

test_cloud_tasks.py is deliberately left out — #72846 already covers it.

They all follow the three checks the existing test_bigquery.py (#68066) in the same
directory uses: the class attributes, the persist XCom payload, and the _format_link
output. A few modules needed extra cases and those are called out in the individual PRs —
KubernetesEngineClusterLink and the two output_config translate links override persist,
and Cloud Functions, Compute, DLP, Dataproc, Translate and the Data Fusion instance link
build their constants on BASE_LINK so _format_link does not prefix the console base a
second time.

One thing worth flagging: because these all delete adjacent lines from the same
OVERLOOKED_TESTS block, they will conflict with each other as they merge. I will rebase the
remainder every time one lands. If you would rather review fewer PRs, say so and I will squash
them into a handful of grouped ones instead.

Closing this as obsolete.

The checklist in the description predates the provider restructure. All 182 paths in it use the old tests/providers/... layout, which no longer exists, so neither the checked nor the unchecked entries map onto files in the repo today. The gap itself is not closed: OVERLOOKED_TESTS currently carries 267 entries, more than this list ever tracked.

That in-code list is the live source of truth and test_providers_modules_should_have_tests enforces it, so it cannot go stale the way this description did:

airflow/airflow-core/tests/unit/always/test_project_structure.py

Lines 57 to 63 in d076a57

    
               def test_providers_modules_should_have_tests(self): 
        
                   """ 
        
                   Assert every module in /providers/ has a corresponding test_ file in providers/providers. 
        
                   """ 
        
                   # The test below had a but for quite a while and we missed a lot of modules to have tess 
        
                   # We should make sure that one goes to 0 
        
                   OVERLOOKED_TESTS = [

Anyone who wants to fill one of these in can read the current list there. Open PRs already doing so are not affected by this closure.

One request for anyone picking these up: group them. A module at a time, claimed in a comment and opened as its own PR, means one review and one CI run per file, and they are all the same review. Batch a provider's worth of missing test modules into a single PR instead.

Add missing unit tests for common.compat lineage entities (apache#72506)

Add missing unit tests for the common-messaging provider base class (a…

Add missing unit tests for the Celery default configuration builder

Navigation Menu

Repository navigation

Add missing test modules in our unit test suite #35442

Provider amazon

Provider apache.cassandra

Provider apache.drill

Provider apache.druid

Provider apache.hdfs

Provider apache.hive

Provider apache.kafka

Provider celery

Provider cncf.kubernetes

Provider common.io

Provider databricks

Provider dbt.cloud

Provider docker

Provider elasticsearch

Provider google

Provider microsoft.azure

Provider mongo

Provider openlineage

Provider presto

Provider redis

Provider slack

Provider snowflake

Provider trino

Committer

49 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	def test_providers_modules_should_have_tests(self):
	"""
	Assert every module in /providers/ has a corresponding test_ file in providers/providers.
	"""
	# The test below had a but for quite a while and we missed a lot of modules to have tess
	# We should make sure that one goes to 0
	OVERLOOKED_TESTS = [

Add missing test modules in our unit test suite #35442

Description

Provider amazon

Provider apache.cassandra

Provider apache.drill

Provider apache.druid

Provider apache.hdfs

Provider apache.hive

Provider apache.kafka

Provider celery

Provider cncf.kubernetes

Provider common.io

Provider databricks

Provider dbt.cloud

Provider docker

Provider elasticsearch

Provider google

Provider microsoft.azure

Provider mongo

Provider openlineage

Provider presto

Provider redis

Provider slack

Provider snowflake

Provider trino

Committer

Activity

potiuk commented on Nov 4, 2023

potiuk commented on Nov 5, 2023

potiuk commented on Nov 5, 2023

potiuk commented on Nov 5, 2023

Taragolis commented on Nov 5, 2023

Taragolis commented on Nov 5, 2023

Taragolis commented on Nov 5, 2023

eladkal commented on Nov 5, 2023

49 remaining items

keith991001 commented on Sep 11, 2026

ShousenZHANG commented on Sep 11, 2026

ShousenZHANG commented on Sep 11, 2026

kaxil commented on Sep 11, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions