Skip to content

Add unit tests for the Cloud Build links - #72961

Closed
ShousenZHANG wants to merge 1 commit into
apache:mainfrom
ShousenZHANG:add-tests-cloud-build-links
Closed

Add unit tests for the Cloud Build links#72961
ShousenZHANG wants to merge 1 commit into
apache:mainfrom
ShousenZHANG:add-tests-cloud-build-links

Conversation

@ShousenZHANG

@ShousenZHANG ShousenZHANG commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

providers/google/tests/unit/google/cloud/links/test_cloud_build.py was listed in OVERLOOKED_TESTS, so CloudBuildLink, CloudBuildListLink, CloudBuildTriggersListLink and CloudBuildTriggerDetailsLink had no coverage.

Adds the checks the sibling link tests use, for each class:

  • test_class_attributes — key, name, format_str
  • test_persist — the XCom payload pushed by BaseGoogleLink.persist
  • test_format_link — the _format_link output

Same shape as test_bigquery.py (added in #68066) in the same directory, and the OVERLOOKED_TESTS entry is removed in this PR.

related: #35442

Was generative AI tooling used to co-author this PR?

  • Yes

Generated-by: Claude Code

The test bodies were written by an AI assistant following the existing test_bigquery.py pattern in the same directory. I verified them myself:

  • pytest providers/google/tests/unit/google/cloud/links/test_cloud_build.py — 12 passed
  • pytest airflow-core/tests/unit/always/test_project_structure.py — 10 passed, 1 xfailed
  • ruff check / ruff format --check on the test file — clean
  • prek run --files providers/google/tests/unit/google/cloud/links/test_cloud_build.py airflow-core/tests/unit/always/test_project_structure.py — 43 passed, 212 skipped, 0 failed

@ShousenZHANG
Add unit tests for the Cloud Build links
82a7154 
`providers/google/tests/unit/google/cloud/links/test_cloud_build.py` was
listed in `OVERLOOKED_TESTS`, so `CloudBuildLink`, `CloudBuildListLink`,
`CloudBuildTriggersListLink` and `CloudBuildTriggerDetailsLink` had no
coverage.

Adds class-attribute, `persist` and `_format_link` checks for each of them,
following the shape of `test_bigquery.py` in the same directory.

Drops the path from `OVERLOOKED_TESTS`.

related: #35442

Generated-by: Claude Code
Copilot AI lite review requested due to automatic review settings September 11, 2026 14:59
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Sep 11, 2026
Copilot AI reviewed Sep 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ShousenZHANG ShousenZHANG mentioned this pull request Sep 11, 2026
Closed
@kaxil

kaxil commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closing this along with the other 19 PRs opened from this account today.

These are the first 20 PRs from this account, and 17 of them were opened inside a two-minute window, between 14:59:50Z and 15:01:43Z, about seven seconds apart. Each carries Generated-by: Claude Code in both the description and the commit message. The disclosure is appreciated, but a batch of 20 generated PRs arriving at once is the load the Gen-AI assisted contributions guidelines ask contributors not to create: it is 20 separate reviews, and CI has to run all of them.

Airflow is maintained by volunteers, so every PR costs reviewer time and CI capacity.

@kaxil kaxil added AI Spam closed because of multiple quality violations Label used to close the PRs when there are multiple quality violations labels Sep 11, 2026
@kaxil kaxil closed this Sep 11, 2026
@kaxil

kaxil commented Sep 11, 2026

Copy link
Copy Markdown
Member

Also, one PR per module is the wrong unit: twenty PRs for one logical change is twenty reviews and twenty CI runs, when it should have been a single PR.

The tests add little on their own merits either, since test_class_attributes compares format_str against the same constant imported from the module under test, and test_format_link derives its expected value from the same .format() call the implementation makes, so a broken link string still passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@shahar1 shahar1 Awaiting requested review from shahar1 shahar1 is a code owner

Assignees

No one assigned

Labels

AI Spam area:providers closed because of multiple quality violations Label used to close the PRs when there are multiple quality violations provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShousenZHANG @kaxil