Repository navigation
Add missing unit tests for the common-messaging provider base class - #72915
Merged
vincbeck merged 1 commit intoSep 11, 2026
Merged
Conversation
The module was listed in OVERLOOKED_TESTS in test_project_structure.py; covering the scheme-matching contract shrinks the guard list further (related: apache#35442).
1 task
vincbeck
approved these changes
Sep 11, 2026
xvega
pushed a commit
to xvega/airflow
that referenced
this pull request
Sep 13, 2026
…pache#72915) The module was listed in OVERLOOKED_TESTS in test_project_structure.py; covering the scheme-matching contract shrinks the guard list further (related: apache#35442).
dlactin
pushed a commit
to dlactin/airflow
that referenced
this pull request
Sep 14, 2026
…pache#72915) The module was listed in OVERLOOKED_TESTS in test_project_structure.py; covering the scheme-matching contract shrinks the guard list further (related: apache#35442).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing test module for
airflow.providers.common.messaging.providers.base_providerand removes its entry fromOVERLOOKED_TESTSintest_project_structure.py, per the checklist in the meta issue.The tests cover the concrete surface of
BaseMessageQueueProvider:scheme_matchesacross matching / non-matching / empty / None schemes, the base-classscheme = Nonedefault matching nothing, and markers asserting which contract methods are declared abstract (and thatscheme_matchesis not).While writing these I noticed the declared abstract contract is out of sync with the in-tree providers (three of them implement only
trigger_class, which currently goes unenforced because the base class does not inheritabc.ABC) — that needs a maintainer decision on direction, so it is filed separately rather than "fixed" here; the tests deliberately avoid enshrining the unenforced behavior.10 tests, all passing locally via
uv run --project providers/common/messaging pytest ...; thetest_providers_modules_should_have_testsguard passes with the entry removed.related: #35442
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines