Repository navigation
Add unit tests for the Cloud Datastore links - #72956
ShousenZHANG wants to merge 1 commit into
Conversation
`providers/google/tests/unit/google/cloud/links/test_datastore.py` was listed in `OVERLOOKED_TESTS`, so `CloudDatastoreImportExportLink` and `CloudDatastoreEntitiesLink` had no coverage. Adds class-attribute, `persist` and `_format_link` checks for both, following the shape of `test_bigquery.py` in the same directory. `DATASTORE_EXPORT_ENTITIES_LINK` is left alone: the constant is defined in the module but no link class uses it, so there is nothing to assert about it here. Drops the path from `OVERLOOKED_TESTS`. related: #35442 Generated-by: Claude Code
boring-cyborg
Bot
added
area:providers
provider:google
|
Look nice! Thanks for the contribution! |
|
Closing this along with the other 19 PRs opened from this account today. These are the first 20 PRs from this account, and 17 of them were opened inside a two-minute window, between 14:59:50Z and 15:01:43Z, about seven seconds apart. Each carries Airflow is maintained by volunteers, so every PR costs reviewer time and CI capacity. |
kaxil
added
AI Spam
closed because of multiple quality violations
|
Also, one PR per module is the wrong unit: twenty PRs for one logical change is twenty reviews and twenty CI runs, when it should have been a single PR. The tests add little on their own merits either, since |
providers/google/tests/unit/google/cloud/links/test_datastore.pywas listed inOVERLOOKED_TESTS, soCloudDatastoreImportExportLinkandCloudDatastoreEntitiesLinkhad no coverage.Adds class-attribute,
persistand_format_linkchecks for both, following the shape oftest_bigquery.pyin the same directory.One thing I deliberately left out:
DATASTORE_EXPORT_ENTITIES_LINKis defined in the module but no link class references it, so there is nothing to assert about it here. Flagging it in case that is an oversight worth a separate look.The
OVERLOOKED_TESTSentry is removed in this PR.Third in the series after #72949 (
bigquery_dts) and #72955 (dataprep).related: #35442
Was generative AI tooling used to co-author this PR?
Generated-by: Claude CodeThe test bodies were written by an AI assistant following the existing
test_bigquery.pypattern in the same directory. I verified them myself:pytest providers/google/tests/unit/google/cloud/links/test_datastore.py— 6 passedpytest airflow-core/tests/unit/always/test_project_structure.py— 10 passed, 1 pre-existing xfailprek run --files <both files>— 43 passed, 212 skipped, 0 failed