Skip to content

Add missing unit tests for common.compat lineage entities - #72506

Merged
potiuk merged 1 commit into
apache:mainfrom
keith991001:add-lineage-entities-tests
Sep 10, 2026
Merged

potiuk merged 1 commit into
apache:mainfrom
keith991001:add-lineage-entities-tests

Conversation

@keith991001

Copy link
Copy Markdown
Contributor

Adds the missing test module for airflow.providers.common.compat.lineage.entities and removes its entry from OVERLOOKED_TESTS in test_project_structure.py, per the checklist in the meta issue.

The new tests cover the five attrs entities (File, User, Tag, Column, Table): keyword-only and required-field enforcement, defaults, value-based equality, template_fields contents, nested attr.asdict serialization, and the default_if_none converter helper.

related: #35442


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Fable 5)

Generated-by: Claude Code (Fable 5) following the guidelines

@boring-cyborg

boring-cyborg Bot commented Sep 4, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@keith991001

Copy link
Copy Markdown
Contributor Author

Note on the red Compat 2.11.1:P3.10 lane: the new test_entities.py module itself passed all 21 tests there — the failure is providers/openlineage/tests/unit/openlineage/plugins/test_execution.py::test_short_stalled_task_extraction_with_low_execution_is_killed_by_ol_timeout, a timing-sensitive test unrelated to this PR (which only adds a test module under common/compat). A re-run should clear it.


Drafted-by: Claude Code (Fable 5) (no human review before posting)

The module was listed in OVERLOOKED_TESTS in test_project_structure.py;
covering it lets the guard list shrink toward zero (related: apache#35442).
@keith991001
keith991001 force-pushed the add-lineage-entities-tests branch from 711d225 to 71cafc0 Compare September 10, 2026 02:07
@keith991001

Copy link
Copy Markdown
Contributor Author

@potiuk
gentle reminder— this PR is approved, rebased onto latest main (the conflict with #72509 is resolved), and CI is fully green. Since OVERLOOKED_TESTS in test_project_structure.py is a high-churn file, it tends to conflict again if it sits — would appreciate a merge when you have a moment. Thanks!

@potiuk
potiuk merged commit 9bd7d14 into apache:main Sep 10, 2026
111 checks passed
imrichardwu pushed a commit to imrichardwu/airflow that referenced this pull request Sep 11, 2026
The module was listed in OVERLOOKED_TESTS in test_project_structure.py;
covering it lets the guard list shrink toward zero (related: apache#35442).
xvega pushed a commit to xvega/airflow that referenced this pull request Sep 13, 2026
The module was listed in OVERLOOKED_TESTS in test_project_structure.py;
covering it lets the guard list shrink toward zero (related: apache#35442).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants