Skip to content

Fix createOnDemand for Rolling File Appender - #4072

Merged
vy merged 5 commits into
apache:2.xfrom
ramanathan1504:issue-2006
May 21, 2026
Merged

vy merged 5 commits into
apache:2.xfrom
ramanathan1504:issue-2006

Conversation

@ramanathan1504

@ramanathan1504 ramanathan1504 commented Mar 20, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #2006

PR Notes: RollingFile createOnDemand validation

Scope

  • Module tested: spring-boot-test only
  • core-java-test and log4j2-web-test left unchanged

What was run

  • Local dependency check confirmed 2.26.0-SNAPSHOT artifacts resolved from ~/.m2
  • Startup timing probes from SpringBootTestApp#printLogPathState used as source of truth

Results (2.26.0-SNAPSHOT)

createOnDemand="true" (default log4j2.xml)

  • main-entry: dir=false app.log=false app-json.log=false
  • after LogManager.getLogger: dir=false app.log=false app-json.log=false
  • after first log event: dir=true app.log=true app-json.log=true

Conclusion: directory and files are created on first log event (expected on-demand behavior).

createOnDemand="false" (log4j2-createOnDemand-false.xml)

  • main-entry: dir=false app.log=false app-json.log=false
  • after LogManager.getLogger: dir=true app.log=true app-json.log=true
  • after first log event: dir=true app.log=true app-json.log=true

Conclusion: eager creation occurs before first log event (expected non-demand behavior).

@ramanathan1504 ramanathan1504 changed the title [LOG4J2-issue-2006] RollingFile createOnDemand validation [LOG4J2-2006] RollingFile createOnDemand validation Mar 20, 2026
@vy vy changed the title [LOG4J2-2006] RollingFile createOnDemand validation Fix createOnDemand for Rolling File Appender Apr 23, 2026

@vy vy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with @ppkarwasz, the fix looks good. Could you also add a changelog entry (referencing to both the Issue and PR IDs), please?

@github-project-automation github-project-automation Bot moved this to Changes requested in Log4j pull request tracker Apr 23, 2026
@vy

vy commented Apr 23, 2026

Copy link
Copy Markdown
Member

@ramanathan1504, if you can get this merged until next week, I can ship it with 2.26.0.

@ramanathan1504

Copy link
Copy Markdown
Contributor Author

@ramanathan1504, if you can get this merged until next week, I can ship it with 2.26.0.
@vy within a day i will complete👍

@vy

vy commented Apr 24, 2026

Copy link
Copy Markdown
Member

@ramanathan1504, please do NOT force-push. It truncates the entire conversation history and I cannot see what incremental changes you've pushed. That is, I need to re-review everything from scratch.

Comment thread src/changelog/2.6/LOG4J2-2006_Fix_RollingFileAppender_createOnDemand.xml Outdated
@ramanathan1504

Copy link
Copy Markdown
Contributor Author

@ramanathan1504, please do NOT force-push. It truncates the entire conversation history and I cannot see what incremental changes you've pushed. That is, I need to re-review everything from scratch.

@vy Thanks for the clarification. I will avoid force-pushing and will push incremental commits.

…tion until the first log event change log moving from 2.6 to 2.x
@ramanathan1504
ramanathan1504 requested a review from vy April 24, 2026 07:59
@github-project-automation github-project-automation Bot moved this from Changes requested to Approved in Log4j pull request tracker Apr 24, 2026
@vy
vy enabled auto-merge (squash) April 24, 2026 08:27
@vy
vy merged commit 878f951 into apache:2.x May 21, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Log4j pull request tracker May 21, 2026
vy added a commit that referenced this pull request Jul 1, 2026
Co-authored-by: Piotr P. Karwasz <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>
ramanathan1504 added a commit to ramanathan1504/logging-log4j2 that referenced this pull request Jul 9, 2026
Co-authored-by: Piotr P. Karwasz <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>
ramanathan1504 added a commit that referenced this pull request Jul 24, 2026
#4118)

* Fix NPE in ConfigurationScheduler by ensuring scheduledFuture is checked for null before accessing its methods; add test for race condition in scheduling.

* Restrict JUnit dependencies to below version 6.x to maintain compatib… (#4120)

* Restrict JUnit dependencies to below version 6.x to maintain compatibility with Java 8

* Update JUnit dependency restrictions for compatibility with Java 8 on 2.x

* Don't override `apache-rat-plugin` version (#4123)

Remove the version override for `apache-rat-plugin` so it falls back to the version provided by the ASF Parent POM.

Apache RAT `0.18`, for which Dependabot opened an update PR, contains a bug ([RAT-552](https://issues.apache.org/jira/browse/RAT-552)) that effectively disables the `excludeSubProjects` plugin option whenever `<excludes>` is present in the configuration.

Upgrading to `0.18` will require converting our `<excludes>` to `<inputExcludes>`, which depends on a new `logging-parent` release.

* Bump actions/stale from 9.1.0 to 10.2.0 in the dependencies group across 1 directory (#4121)

* Bump actions/stale in the dependencies group across 1 directory

Bumps the dependencies group with 1 update in the / directory: [actions/stale](https://github.com/actions/stale).


Updates `actions/stale` from 9.1.0 to 10.2.0
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@5bef64f...b5d41d4)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: 10.2.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>

* Generate changelog entries for #4121

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix KafkaAppender reporting error after successful retry (#4125)

* Fix KafkaAppender reporting error after successful retry

When retryCount is configured and the initial tryAppend() fails, the
retry loop uses break to exit on success. However, break only exits the
while loop and execution always reaches the error() call afterward. This
causes spurious error notifications for transient Kafka failures that
were successfully recovered by a retry.

Replace break with return so that a successful retry exits append()
without reporting an error. Retry exceptions are now logged at DEBUG
level for diagnostics instead of being silently discarded.

Also remove dead code in Builder.getRetryCount() where Integer.valueOf(int)
was wrapped in a NumberFormatException catch that can never fire.

The bug was introduced in #315.

Signed-off-by: Sebastien Tardif <[email protected]>

* Add changelog entry for KafkaAppender retry fix

Signed-off-by: Sebastien Tardif <[email protected]>

* Use CloseableThreadContext in testRetrySuccessDoesNotReportError

Adopt reviewer suggestion to use try-with-resources CloseableThreadContext
instead of manual ThreadContext.put/clearMap.

---------

Signed-off-by: Sebastien Tardif <[email protected]>

* Revamped `ListAppender` for thread-safety (#4111)

Co-authored-by: Björn Michael <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>

* Improve `CronExpression` tests to cover daylight saving and scheduling logic (#4081)

Co-authored-by: Piotr P. Karwasz <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>

* Fix `createOnDemand` for Rolling File Appender (#4072)

Co-authored-by: Piotr P. Karwasz <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>

* Add support for max compression delay in compression actions (#4071)

Co-authored-by: Volkan Yazıcı <[email protected]>

* Improve logging for `LinkageError` scenarios involving the LMAX Disruptor library (#4124)

Co-authored-by: Volkan Yazıcı <[email protected]>

* Fix changelog issue and PR references for Disruptor initialization error logging (#2250, #4124, #4134)

* Fix encoding of `MSGID` and `SD-ID` fields of `StructuredDataMessage` to XML (#4136)

* Fix stack trace rendering for exceptions with identity malfunction (#4133)

* Fix circular reference detection for exceptions with colliding equals/hashCode implementations

* Add changelog entry for circular reference detection fix with colliding equals/hashCode exceptions

* Add changelog entry for circular reference detection fix with colliding equals/hashCode exceptions

* Add test for ThrowableProxy serialization with colliding equals/hashCode implementations

* Refactor ThrowableProxy serialization test to use modern Java I/O classes

* Use `TestFriendlyException` to exercise the malfunction

* Update changelog

* Improve comments

* Remove redundant change

---------

Co-authored-by: Volkan Yazıcı <[email protected]>

* Remove the `patternFlags` attribute from `RegexFilter` (#4119)

Co-authored-by: Jeff Thomas <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>

* Fix `DatePatternConverter` locale parsing when timezone is omitted (#4130)

* Harden `readObject(ObjectInputStream)` method argument checks (#4098)

Signed-off-by: SunWeb3Sec <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>

* Fix resource leaks in `ConfigurationSource` when loading via URL (#4127)

Signed-off-by: Sebastien Tardif <[email protected]>
Co-authored-by: Ramanathan <[email protected]>
Co-authored-by: Piotr P. Karwasz <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>

* Adopt the Dependabot changelog 'draft trick' (#4148)

Applies the consumer-side changes from logging-parent PR #476:

* `build.yaml` and `codeql-analysis.yaml` now subscribe to the
  `ready_for_review` pull request type, so required checks re-run when a
  Dependabot PR is taken out of draft.
* `process-dependabot.yaml` drops the `RECURSIVE_TOKEN` PAT secret, which
  is no longer needed now that the reusable workflow parks the PR in
  draft mode instead of pushing with a privileged token.

Assisted-By: Claude Opus 4.8 (1M context) <[email protected]>

* Add Dependabot config for the 2.26.x maintenance branch (#4149)

Configure a Maven update entry targeting the `2.26.x` branch that only
proposes patch-level upgrades. All dependencies are bundled into a single
`Maven patch updates` group with a 7-day cooldown.

* Fix handling of non-finite numbers while encoding `MapMessage` to JSON (#4163)

* Remove `/log4j-slf4j-impl` Dependabot execution (#4151)

Instead of correcting the target branch, we can safely
remove it: the only dependency version defined in
`log4j-slf4j-impl` is SLF4J 1.x, which is highly unlikely
to see any new releases.

* Upgrade Maven and Maven Wrapper versions to `3.9.16` and `3.3.4`, respectively (#4167)

* Adds `maxRandomDelay` configure to Rolling Appenders (#4165)

* Rework random delay for Rolling Appender action chain

* Stabilize `RollingAppenderDirectCronTest`

* Merge `2.26.1` to `2.x` (#4169)

* Add `2.25.5` release notes (#4174)

* Add native tracing fields to LogEvent to eliminate async MDC overhead (#4171)

* Add tracing fields to RingBufferLogEvent and related classes

* Add W3C trace context support with pattern converters for trace ID, span ID, and trace flags

* Enhance TraceContextProviderService for exception safety and simplify trace ID retrieval

* Add tests for tracing fields serialization and pattern converters

* Refactor tracing metadata documentation and improve code comments for clarity

* Add native W3C tracing fields to LogEvent and introduce TraceContextProvider SPI

* Add benchmark for ContextDataProvider tracing approach

* Enhance TraceContextProviderService to handle SecurityManager restrictions gracefully

* Fix NPE in ConfigurationScheduler by ensuring proper reset of scheduled futures

* Fix NPE in ConfigurationScheduler for frequent cron schedules

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sebastien Tardif <[email protected]>
Signed-off-by: SunWeb3Sec <[email protected]>
Co-authored-by: Piotr P. Karwasz <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sebastien Tardif <[email protected]>
Co-authored-by: Björn Michael <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>
Co-authored-by: Jeff Thomas <[email protected]>
Co-authored-by: SunWeb3Sec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

RollingFileAppender with createOnDemand="true" eagerly tries creating directories

2 participants