Repository navigation
Fix SLF4JLogger.atFatal() returning Level.TRACE instead of Level.FATAL - #4089
Merged
Merged
Conversation
…evel.FATAL (apache#4068) atFatal() was copied from atTrace() in commit 113a8e8 (LOG4J2-3647) and the level constant was never updated. This caused every logger.atFatal().log(...) call through the log4j-to-slf4j bridge to emit at TRACE level, silently discarding the message in any environment where TRACE is disabled. Fix: change Level.TRACE to Level.FATAL in SLF4JLogger.atFatal().
Member
|
High @cookiejack15, Thank you for your PR. Could you add a unit test to prevent regressions? |
Verifies that atFatal() produces a log event at ERROR level (SLF4J equivalent of FATAL) instead of being silently discarded as TRACE.
Contributor
Author
|
Hello @ppkarwasz, Thank you for the review. i added a parameterized test in LogBuilderTest that verifies atFatal() produces a log event. Follows the same pattern as the existing testLevelThreshold test |
Contributor
Generated by gradle/develocity-actions |
vy
reviewed
Apr 12, 2026
vy
approved these changes
Apr 12, 2026
vy
enabled auto-merge (squash)
April 12, 2026 08:23
github-project-automation
Bot
moved this from Approved
to Merged
in Log4j pull request tracker
ramanathan1504
pushed a commit
to ramanathan1504/logging-log4j2
that referenced
this pull request
Apr 23, 2026
apache#4089) Co-authored-by: Piotr P. Karwasz <[email protected]> Co-authored-by: Volkan Yazıcı <[email protected]>
ramanathan1504
pushed a commit
to ramanathan1504/logging-log4j2
that referenced
this pull request
Apr 23, 2026
apache#4089) Co-authored-by: Piotr P. Karwasz <[email protected]> Co-authored-by: Volkan Yazıcı <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4068.
Summary
SLF4JLogger.atFatal()returnsatLevel(Level.TRACE)instead ofatLevel(Level.FATAL). This was a copy-paste error introduced in commit113a8e85f4(LOG4J2-3647, 2023-01-13). Everylogger.atFatal().log(...)call through thelog4j-to-slf4jbridge emits at TRACE level, causing the message to be silently discarded in any environment where TRACE is disabled.Changes
SLF4JLogger.java: ChangedLevel.TRACEtoLevel.FATALinatFatal()4068_fix_SLF4JLogger_atFatal_wrong_level.xmlAffected versions
2.20.0 through 2.24.3 (every release since the fluent API was added to the SLF4J bridge).