Repository navigation
Keep parent in flatten-bom configuration #37
Description
Activity
- added a commit that references this issue
on Oct 4, 2023 Reproduction of the issue:
$ git clone https://github.com/apache/logging-log4j-tools.git && cd $_ $ git checkout 18425d95a4d150de905929d55bf55545d70f3d91 $ ./mvnw -N log4j-changelog:export@export-changelog -X ... [INFO] --- log4j-changelog:0.5.0:export (export-changelog) @ log4j-tools-bom --- [WARNING] The POM for org.apache.logging.log4j:log4j-changelog:jar:0.5.0 is invalid, transitive dependencies (if any) will not be available: 2 problems were encountered while building the effective model for org.apache.logging.log4j:log4j-changelog:0.5.0 [ERROR] 'dependencies.dependency.version' for org.osgi:osgi.annotation:jar is missing. @ [ERROR] 'dependencies.dependency.version' for com.github.spotbugs:spotbugs-annotations:jar is missing. @
flatten-bomconfiguration offlatten-maven-plugindoesn't keep theparent. This causes build failures for artifacts whose dependencies need to be resolved at runtime. Consider the following problem experienced inlog4j-changelog-maven-plugin:log4j-changelog-maven-plugindepends onlog4j-changeloglog4j-changeloginherits fromlog4j-tools-parentlog4j-tools-parentinherits fromlog4j-tools-bomlog4j-tools-bominherits fromlogging-parentlogging-parentcontainsdependencyManagement, etc. entries that are used bylog4j-changelog-maven-pluginlog4j-changelog-maven-pluginet al. is resolved at runtimelog4j-tools-bomis used, which is flattened and hence doesn't have a parent!log4j-transform-maven-pluginexecution fails due to missing logic that should have been inherited fromlogging-parentTo avoid this,
flatten-bomconfiguration should better keep the parent using<parent>keep</parent>inpomElementsblock.