Skip to content

[MSHARED-1109] Ignore MessageUtilsTest methods on unsupported platforms - #106

Merged
asfgit merged 1 commit into
apache:masterfrom
kwin:bugfix/fix-messageutilstest-on-apple-silicon
Jul 25, 2022
Merged

[MSHARED-1109] Ignore MessageUtilsTest methods on unsupported platforms#106
asfgit merged 1 commit into
apache:masterfrom
kwin:bugfix/fix-messageutilstest-on-apple-silicon

Conversation

@kwin

@kwin kwin commented Jul 25, 2022

Copy link
Copy Markdown
Member

No description provided.

michael-o
michael-o requested changes Jul 25, 2022
View reviewed changes
Comment thread src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java Outdated
Comment thread src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java Outdated
Comment thread src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java Outdated
Comment thread src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java Outdated
Comment thread src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java Outdated
@kwin

kwin commented Jul 25, 2022

Copy link
Copy Markdown
Member Author

I don't think the test failure is related (https://github.com/apache/maven-shared-utils/runs/7501384171?check_suite_focus=true)

Error:  Failures: 
Error:    MessageUtilsTest.testSystem:50 
Expected: sameInstance(<org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream@12d3a4e9>)
     but: was <AnsiPrintStream{type=Redirected, colors=Colors16, mode=Strip, resetAtUninstall=true}>

@michael-o

michael-o commented Jul 25, 2022

Copy link
Copy Markdown
Member

I don't think the test failure is related (https://github.com/apache/maven-shared-utils/runs/7501384171?check_suite_focus=true)

Error:  Failures: 
Error:    MessageUtilsTest.testSystem:50 
Expected: sameInstance(<org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream@12d3a4e9>)
     but: was <AnsiPrintStream{type=Redirected, colors=Colors16, mode=Strip, resetAtUninstall=true}>

Correct, since the test expect Jansi to work it does not notice that the OS is not wrapped.

michael-o
michael-o approved these changes Jul 25, 2022
View reviewed changes

@michael-o michael-o left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the issue on HP-UX for me as well.

michael-o pushed a commit to kwin/maven-shared-utils that referenced this pull request Jul 25, 2022
@kwin @michael-o
[MSHARED-1109] MessageUtilsTest fails on unsupported platforms (e.g.,…
3f380dd 
… Apple Silicon or HP-UX/IA64)

This closes apache#106
@michael-o
michael-o force-pushed the bugfix/fix-messageutilstest-on-apple-silicon branch from 65157b0 to 3f380dd Compare July 25, 2022 14:18
kwin
kwin commented Jul 25, 2022
View reviewed changes
Comment thread src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java Outdated
@michael-o
michael-o force-pushed the bugfix/fix-messageutilstest-on-apple-silicon branch from 3f380dd to 8822bea Compare July 25, 2022 14:21
@asfgit
asfgit merged commit 8822bea into apache:master Jul 25, 2022
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Apr 29, 2023
@jira-importer

jira-importer commented Jul 3, 2025

Copy link
Copy Markdown

Resolve #310

@jira-importer jira-importer mentioned this pull request Sep 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kwin @michael-o @jira-importer @asfgit @slawekjaranowski