Repository navigation
PathTool.getRelativeFilePath: return empty string instead of null for cross-drive paths - #403
Merged
Merged
Conversation
… cross-drive paths
elharo
commented
Jul 1, 2026
|
|
||
| @Test | ||
| // Keep in sync with testGetRelativeFilePathNonWindows() | ||
| // Keep in sync with testGetRelativeFilePathWindows() |
Contributor
Author
There was a problem hiding this comment.
I think this comment was accurate and should not be changed
desruisseaux
approved these changes
Aug 3, 2026
desruisseaux
left a comment
desruisseaux
left a comment
There was a problem hiding this comment.
I'm not familiar with the context in which this method was used. But it is a deprecated method anyway, so hopefully the method is not widely used and therefore the risk is low.
slachiewicz
added a commit
that referenced
this pull request
Sep 10, 2026
#403 changed getRelativeFilePath to return an empty string rather than null when the two paths are on different Windows drives. #384 was branched before that and merged the same day without a rebase, so its new test still asserted null and master has been red since. Do not restore assertNull here: #403 is the newer contract, and two other tests in this class already assert the empty string. Verified: mvn -B verify on JDK 17 -> Tests run: 787, Failures: 0
slachiewicz
added a commit
that referenced
this pull request
Sep 10, 2026
#403 changed getRelativeFilePath to return an empty string rather than null when the two paths are on different Windows drives. #384 was branched before that and merged the same day without a rebase, so its new test still asserted null and master has been red since. Do not restore assertNull here: #403 is the newer contract, and two other tests in this class already assert the empty string. Verified: mvn -B verify on JDK 17 -> Tests run: 787, Failures: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402