Repository navigation
Deprecate the logging package in favor of MessageBuilderFactory - #423
Merged
Merged
Conversation
Maven 3.10.0 introduces org.apache.maven.message.MessageBuilderFactory, and Maven 4 org.apache.maven.api.services.MessageBuilderFactory, which supersede this package. This is the outcome of the review on #377, which proposed swapping Jansi for org.jline:jansi here. That swap was rejected: Maven exports this package up to 3.9.x and many plugins compile against it, so changing the ANSI provider underneath them is not safe. Deprecation is the agreed route instead. The package-private implementations are marked too, so implementing a deprecated interface does not warn.
slachiewicz
added
deprecated
slachiewicz
marked this pull request as ready for review
September 10, 2026 07:54
elharo
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
org.apache.maven.shared.utils.logging. Maven 3.10.0 introducesorg.apache.maven.message.MessageBuilderFactoryand Maven 4org.apache.maven.api.services.MessageBuilderFactory, both of which supersede it.This is the outcome of the review on #377, which proposed swapping Jansi for
org.jline:jansihere:Marking the package-private implementations as well keeps the build free of warnings for implementing a deprecated interface. No behaviour changes and no signature changes, so this is source and binary compatible.
Closes #373.
Verified:
mvn -B verifyon JDK 17 -> Tests run: 787, Failures: 0, Errors: 0. Spotless clean.This change was created with AI assistance.