Repository navigation
build(deps): replace fusesource.jansi with jline.jansi for ANSI support - #377
HarshMehta112 wants to merge 1 commit into
Conversation
Signed-off-by: Harsh Mehta <[email protected]>
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
It is no so easy, this class is used by Maven until 3.9.x and many plugins ....
Maven also exports such packages
In Maven 3.10.x we will MessageBuilderFactory class.
So I will not touch it, we can make it deprecated.
Maven 3.10.0 introduces org.apache.maven.message.MessageBuilderFactory, and Maven 4 org.apache.maven.api.services.MessageBuilderFactory, which supersede this package. This is the outcome of the review on #377, which proposed swapping Jansi for org.jline:jansi here. That swap was rejected: Maven exports this package up to 3.9.x and many plugins compile against it, so changing the ANSI provider underneath them is not safe. Deprecation is the agreed route instead. The package-private implementations are marked too, so implementing a deprecated interface does not warn.
Maven 3.10.0 introduces org.apache.maven.message.MessageBuilderFactory, and Maven 4 org.apache.maven.api.services.MessageBuilderFactory, which supersede this package. This is the outcome of the review on #377, which proposed swapping Jansi for org.jline:jansi here. That swap was rejected: Maven exports this package up to 3.9.x and many plugins compile against it, so changing the ANSI provider underneath them is not safe. Deprecation is the agreed route instead. The package-private implementations are marked too, so implementing a deprecated interface does not warn.
|
Closing this in favour of deprecating the package instead, per the review here. The blocker is that That deprecation is now up as PR #423, which also closes #373. Thanks for the patch, and sorry it did not land -- the constraint only surfaced in review. The Java 8 analysis you did on Your branch This comment was created with AI assistance. |
Maven 3.10.0 introduces org.apache.maven.message.MessageBuilderFactory, and Maven 4 org.apache.maven.api.services.MessageBuilderFactory, which supersede this package. This is the outcome of the review on #377, which proposed swapping Jansi for org.jline:jansi here. That swap was rejected: Maven exports this package up to 3.9.x and many plugins compile against it, so changing the ANSI provider underneath them is not safe. Deprecation is the agreed route instead. The package-private implementations are marked too, so implementing a deprecated interface does not warn.
3 participants
Fixes #373
Changes
org.jline:jansito version3.25.1(last version supporting Java 8)maven-shared-utilsNotes
jansinewer than3.25.1require Java 11+, so they cannot be used while maintaining Java 8 support.Summary
This update preserves Java 8 compatibility while keeping the dependency as up to date as possible within supported constraints.