Repository navigation
[feat] PIP-335: Add support Oxia as a metadata store - #22007
Merged
Merged
Conversation
merlimat
added
type/feature
merlimat
requested review from
Technoboy-,
codelipenghui,
hangc0276 and
lhotari
January 31, 2024 09:11
github-actions
Bot
added
the
doc-required
merlimat
changed the title
mattisonchao
approved these changes
Jan 31, 2024
Member
|
This PR seems to require a PIP, could you make a PIP? |
BewareMyPower
requested changes
Jan 31, 2024
Contributor
|
And I agree with @nodece that we need a PIP for introducing a new plugin to the broker side. |
Contributor
Author
|
Ok, I can create a PIP, similar to Etcd support. |
merlimat
changed the title
Contributor
Author
hangc0276
approved these changes
Feb 1, 2024
coderzc
approved these changes
Feb 1, 2024
eolivelli
approved these changes
Feb 1, 2024
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM
Looking forward to see it in action
BewareMyPower
approved these changes
Feb 1, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
4 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for Oxia (https://github.com/streamnative/oxia) as a possible metadata store backed.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: