Repository navigation
[fix][proxy] Close channel on connection failure - #25770
Merged
nodece merged 1 commit intoMay 14, 2026
Merged
Conversation
nodece
force-pushed
the
close-channel-on-connection-fail-on-proxy
branch
from
May 14, 2026 02:27
c41dffa to
2c32ebe
Compare
nodece
force-pushed
the
close-channel-on-connection-fail-on-proxy
branch
from
May 14, 2026 02:29
2c32ebe to
bd3698a
Compare
lhotari
pushed a commit
that referenced
this pull request
May 18, 2026
(cherry picked from commit 35cf8f1)
lhotari
pushed a commit
that referenced
this pull request
May 18, 2026
(cherry picked from commit 35cf8f1)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
(cherry picked from commit 35cf8f1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When establishing a direct proxy connection fails, the outbound channel may remain open until it is cleaned up asynchronously. In some cases, this can leave stale connections or unreleased resources behind, especially during rapid reconnects or connection timeouts.
This change ensures the outbound channel is explicitly closed before closing the inbound channel when connection establishment fails, improving resource cleanup consistency and reducing the risk of leaked or half-open channels.
Modifications
f.channel()) when the connection attempt fails before closing the inbound channel.