Repository navigation
[fix][broker] Fix PulsarService.closeAsync where Condition.signalAll was called without holding a lock - #25777
Merged
Merged
Conversation
added 2 commits
May 15, 2026 01:25
merlimat
reviewed
May 14, 2026
Contributor
Author
|
@merlimat Fixed. |
nodece
approved these changes
May 15, 2026
dao-jun
approved these changes
May 15, 2026
dao-jun
added
area/broker
type/bug
lhotari
changed the title
lhotari
approved these changes
May 15, 2026
lhotari
left a comment
lhotari
left a comment
Member
There was a problem hiding this comment.
LGTM, good catch! This explains some flakiness that has been related to PulsarService.closeAsync in tests.
lhotari
pushed a commit
that referenced
this pull request
May 18, 2026
…was called without holding a lock (#25777) Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit a200088)
lhotari
pushed a commit
that referenced
this pull request
May 18, 2026
…was called without holding a lock (#25777) Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit a200088)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…was called without holding a lock (apache#25777) Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit a200088)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 9, 2026
…was called without holding a lock (apache#25777) Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit a200088) (cherry picked from commit 7a9b5c7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In
PulsarService.closeAsync(), thecloseFuture.handle()callback callsisClosedCondition.signalAll()without acquiring the associated mutex lock.Modifications
testWaitUntilClosedConcurrentWithCloseAsyncinPulsarServiceCloseTestthat callswaitUntilClosed()concurrently withcloseAsync().If the box was checked, please highlight the changes