Repository navigation
[fix][client] Fix unAckedMessageTracker cleanup on multi-topics batch ack - #26001
Merged
lhotari merged 3 commits intoJul 25, 2026
Merged
Conversation
… ack Signed-off-by: Dream95 <[email protected]>
void-ptr974
approved these changes
Jun 13, 2026
…consumer-batch-ack-tracker
Contributor
Author
|
The previous CI failure has been fixed on master. @lhotari Please approve the pending workflows. Thanks! |
lhotari
approved these changes
Jun 23, 2026
dao-jun
approved these changes
Jun 24, 2026
lhotari
added
release/4.2.4
release/4.0.13
and removed
release/4.2.3
release/4.0.12
labels
lhotari
pushed a commit
that referenced
this pull request
Jul 26, 2026
… ack (#26001) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 3ebf796)
lhotari
pushed a commit
that referenced
this pull request
Jul 26, 2026
… ack (#26001) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 3ebf796)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
… ack (apache#26001) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 3ebf796)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
… ack (apache#26001) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 3ebf796)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
… ack (apache#26001) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 3ebf796)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 28, 2026
… ack (apache#26001) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 3ebf796)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes a bug in
MultiTopicsConsumerImpl.doAcknowledge(List<MessageId>, ...).When batch acknowledging messages across multiple topics, the success callback used
messageIdList.forEach(unAckedMessageTracker::remove)instead ofmessageIds.forEach(unAckedMessageTracker::remove). As a result, after one underlyingconsumer ack succeeded, all messages in the batch were removed from
unAckedMessageTracker, including messages that had not yet been acked by other consumers.Modifications
MultiTopicsConsumerImpl.doAcknowledge(List<MessageId>, ...), remove only the per-consumermessageIdsfromunAckedMessageTrackerafter a successful ack.testBatchAcknowledgeRemovesOnlyAckedMessageIdsFromTrackerto verify that completing oneconsumer's batch ack leaves the other consumer's message in the tracker.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes