Repository navigation
[fix][broker] Add missing bundle Prometheus metrics for extensible load manager - #26192
Merged
Merged
Conversation
…ad manager Signed-off-by: Dream95 <[email protected]>
Contributor
|
@Dream95 could you add a test? |
…trics Signed-off-by: Dream95 <[email protected]>
Contributor
Author
|
@Technoboy- The test has been added already. |
Technoboy-
approved these changes
Aug 31, 2026
lhotari
added a commit
that referenced
this pull request
Sep 12, 2026
…manager metrics test Fix the test introduced by 9e5e368 ([fix][broker] Add missing bundle Prometheus metrics for extensible load manager, #26192), cherry-picked from 41255fb. Upstream and branch-4.2 create "my-property/my-ns" in BrokerTestBase.baseSetupCommon() following the V1 topic-name removal (#25304; branch-4.2 commit 735b429). Branch-4.0 retains the older setup, which creates "prop/ns-abc" but not "my-property/my-ns". The backported metrics test used the newer setup's namespace and failed with Namespace not found. Use "prop/ns-abc" for its producer and consumer. Validation: testBundlesMetricsWithExtensibleLoadManager passes; Checkstyle passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23923
Main Issue: #xyz
PIP: #xyz
Motivation
exposeBundlesMetricsInPrometheus=truehas no effect underExtensibleLoadManagerImpl. Bundle metrics such aspulsar_bundle_topics_countare missing from the scrape output.ModularLoadManagerImplalready publishes them.Modifications
If
exposeBundlesMetricsInPrometheusis enabled,ExtensibleLoadManagerImpl.getMetrics()now pullsBrokerService#getBundleStats()and publishes the samebrk_bundle_*metrics and labels thatModularLoadManagerImpluses.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes