Repository navigation
[fix][fn] Return inputSpecs consumerProperties in function GET info - #26217
Merged
Merged
Conversation
Signed-off-by: Dream95 <[email protected]>
nodece
approved these changes
Jul 21, 2026
lhotari
pushed a commit
that referenced
this pull request
Jul 22, 2026
…26217) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 90cba32)
lhotari
pushed a commit
that referenced
this pull request
Jul 22, 2026
…26217) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 90cba32)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
…pache#26217) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 90cba32)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 28, 2026
…pache#26217) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 90cba32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26216
Motivation
Creating or updating a function with
inputSpecs[*].consumerPropertiesworks at runtime, but GET/admin/v3/functions/{tenant}/{namespace}/{function}returns an emptyconsumerPropertiesmap.The values are stored in
FunctionDetailswhen the function is created.FunctionConfigUtils.convert()already writes them into the proto. They are dropped on the way back out becauseconvertFromDetails()never copied them intoConsumerConfig.Modifications
Copy
consumerPropertiesfromConsumerSpecinFunctionConfigUtils.convertFromDetails().Add
testConsumerPropertiesinFunctionConfigUtilsTest.Verifying this change
This change added tests and can be verified as follows:
./gradlew :pulsar-functions:pulsar-functions-utils:test --tests org.apache.pulsar.functions.utils.FunctionConfigUtilsTest.testConsumerPropertiesDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes