Repository navigation
[fix][broker] Send ActiveConsumerChange for non-persistent Failover subscriptions - #26482
Merged
Merged
Conversation
Contributor
Author
|
/pulsarbot rerun-failure-checks |
…ubscriptions Signed-off-by: Dream95 <[email protected]>
lhotari
approved these changes
Sep 12, 2026
lhotari
left a comment
lhotari
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for working on this fix. The dispatcher now reports active-consumer changes for non-persistent Failover subscriptions, and the focused tests cover selection, failover, priority, inactive removal, and closed-dispatcher behavior.
lhotari
pushed a commit
that referenced
this pull request
Sep 14, 2026
…ubscriptions (#26482) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 8158339)
lhotari
pushed a commit
that referenced
this pull request
Sep 14, 2026
…ubscriptions (#26482) Signed-off-by: Dream95 <[email protected]> (cherry picked from commit 8158339)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23941
Motivation
Non-persistent Failover subscriptions did not send ActiveConsumerChange when the active consumer changed. PersistentDispatcherSingleActiveConsumer calls notifyActiveConsumerChanged() from scheduleReadOnActiveConsumer(); in the non-persistent path that method was a no-op.
Clients using ConsumerEventListener on non-persistent Failover topics therefore never got becameActive / becameInactive on failover.
Modifications
In NonPersistentDispatcherSingleActiveConsumer.scheduleReadOnActiveConsumer(), call notifyActiveConsumerChanged(getActiveConsumer()). Non-persistent topics have no cursor, so there is no rewind/read step like on persistent topics.
Extend NonPersistentDispatcherFailoverConsumerTest for add/remove failover, priority-based active selection, and adding a consumer to a closed dispatcher.
Verifying this change
This change added tests and can be verified as follows:
NonPersistentDispatcherFailoverConsumerTest.testActiveConsumerChangeNotifications
NonPersistentDispatcherFailoverConsumerTest.testHigherPriorityConsumerBecomesActive
NonPersistentDispatcherFailoverConsumerTest.testAddConsumerWhenClosed
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes