Repository navigation
[improve][broker] Upgrade bookkeeper to 4.18.1 - #26574
Merged
merlimat merged 3 commits intoSep 15, 2026
Merged
Conversation
merlimat
marked this pull request as ready for review
September 14, 2026 04:01
BookKeeper 4.18.1 casts the main worker pool's threads to ThreadBoundExecutor in the LedgerHandle constructor. The threads of an OrderedScheduler do not implement it, so every mock ledger creation failed with a ClassCastException that PulsarMockBookKeeper reported as BKException -999 (UnexpectedCondition). Give each test owner a separate OrderedExecutor for the mock BookKeeper client, with the same lifecycle as its existing scheduler, which stays in use for everything else.
lhotari
marked this pull request as draft
September 14, 2026 04:47
…hat 4.18.1 is released
merlimat
marked this pull request as ready for review
September 15, 2026 16:52
merlimat
approved these changes
Sep 15, 2026
dao-jun
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Sep 20, 2026
Co-authored-by: Matteo Merli <[email protected]> (cherry picked from commit 1759f73)
dao-jun
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Sep 20, 2026
Co-authored-by: Matteo Merli <[email protected]> (cherry picked from commit 1759f73)
dao-jun
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Sep 20, 2026
Co-authored-by: Matteo Merli <[email protected]> (cherry picked from commit 1759f73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Upgrade bookkeeper to 4.18.1
Modifications
Upgrade bookkeeper to 4.18.1
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
Check the box below or label this PR directly.
Need to update docs?
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: StevenLuMT#21