Repository navigation
[fix][broker] Avoid misleading ownership lock expiry logs during shutdown - #26633
Merged
Merged
Conversation
merlimat
reviewed
Sep 17, 2026
merlimat
approved these changes
Sep 18, 2026
Contributor
Author
|
I checked the current flaky, and it doesn't seem to be caused by the changes in this PR. We can rerun the CI. |
ascentstream-bot
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 1, 2026
…down (apache#26633) (cherry picked from commit 80d27d3)
ascentstream-bot
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 2, 2026
…down (apache#26633) (cherry picked from commit 80d27d3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When broker deregistration fails during shutdown, graceful bundle unloading is skipped and the coordination service releases the remaining ownership locks directly. These locks are still registered in
OwnershipCache, so their release callbacks incorrectly report them as expired at INFO level.This follow-up to #26533 avoids misleading expiry messages during shutdown.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes