Repository navigation
[fix][broker] Apply the role logging anonymizer to topic authorization denial logs - #26642
Merged
Merged
Conversation
…n denial logs The warning logged when a topic operation is not allowed printed authRole and originalPrincipal without going through authenticationRoleLoggingAnonymizer, unlike the other role logs in ServerCnx. DefaultAuthenticationRoleLoggingAnonymizer.anonymize now accepts a null role. originalPrincipal is null for clients that do not connect through a proxy, and the SHA256 and MD5 anonymizers failed on it. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
lhotari
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PIP-402 added
authenticationRoleLoggingAnonymizerso operators can keep roles out of broker logs.The warning
ServerCnx.isTopicOperationAllowedlogs when a topic operation is not allowed stillprinted
authRoleandoriginalPrincipalas is.DefaultAuthenticationRoleLoggingAnonymizer.anonymize(null)also failed with theSHA256andMD5anonymizers, while
originalPrincipalis null for every client that does not connect through a proxy.Modifications
authRoleandoriginalPrincipalthrough the anonymizer in the topic authorization denial log.DefaultAuthenticationRoleLoggingAnonymizer.anonymizefor a null role.Verifying this change
This change added tests and can be verified as follows:
DefaultAuthenticationRoleLoggingAnonymizerTest, covering a null role for every anonymizertype and the anonymized value of a role.
Does this pull request potentially affect one of the following parts:
🤖 Generated with Claude Code