Repository navigation
[fix][meta] Close resources when ZKMetadataStore construction fails - #26673
Merged
merlimat merged 1 commit intoSep 22, 2026
Merged
Conversation
merlimat
approved these changes
Sep 22, 2026
ascentstream-bot
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 1, 2026
…pache#26673) (cherry picked from commit fe56cf3)
ascentstream-bot
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 2, 2026
…pache#26673) (cherry picked from commit fe56cf3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26582
Motivation
When
ZKMetadataStoreconstruction fails while connecting to ZooKeeper, superclass executors have already been created. Since the constructor never returns, the caller cannot close the store. The remaining non-daemon threads can preventinitialize-transaction-coordinator-metadatafrom exiting.Modifications
MetadataStoreException.Verifying this change
This change added tests and can be verified as follows:
ZKMetadataStoreTest.constructorFailureClosesResourcesfails before the fix because the batch flusher remains alive and passes after the fix.ZKSessionTest../gradlew --no-daemon --max-workers=1 quickCheck.Does this pull request potentially affect one of the following parts:
Failed
ZKMetadataStoreconstruction now shuts down the metadata-store executors that were created before the ZooKeeper connection attempt.