Skip to content

version number fix - #467

Closed
CodingCat wants to merge 2 commits into
apache:branch-0.9from
CodingCat:branch-0.9
Closed

CodingCat wants to merge 2 commits into
apache:branch-0.9from
CodingCat:branch-0.9

Conversation

@CodingCat

Copy link
Copy Markdown
Contributor

self-explain

@AmplabJenkins

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

Copy link
Copy Markdown

Merged build started.

@pwendell

Copy link
Copy Markdown
Contributor

This entire comment is actually outdated - mind just removing it?

@CodingCat

Copy link
Copy Markdown
Contributor Author

sure, just did that

@AmplabJenkins

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14293/

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14294/

@andrewor14

Copy link
Copy Markdown
Contributor

Not related to this patch at all, but could you also remove the dummy comment again from your other patch? I think we merged it before it was removed.

https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala#L40

@CodingCat

Copy link
Copy Markdown
Contributor Author

@andrewor14 , ah, sorry about that, I will submit a "hotfix",

@andrewor14

Copy link
Copy Markdown
Contributor

(you could also remove it in this PR)

@pwendell

Copy link
Copy Markdown
Contributor

I merged this. @andrewor14 this PR is actually into branch 0.9 so it's not possible to remove the commnet.

asfgit pushed a commit that referenced this pull request Apr 22, 2014
self-explain

Author: Nan Zhu <[email protected]>

Closes #467 from CodingCat/branch-0.9 and squashes the following commits:

ba36109 [Nan Zhu] remove out-dated comments
9a8810e [Nan Zhu] version number fix
@CodingCat

Copy link
Copy Markdown
Contributor Author

need to close manually now?

@CodingCat CodingCat closed this Apr 22, 2014
j-esse pushed a commit to j-esse/spark that referenced this pull request Jan 24, 2019
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
arjunshroff pushed a commit to arjunshroff/spark that referenced this pull request Nov 24, 2020
RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Aug 15, 2022
MaxGekk added a commit to MaxGekk/spark that referenced this pull request Sep 27, 2026
### What changes were proposed in this pull request?

Task 181's first owed item: the first-query cost, written into the closing post's plan (`PLAN_TASK_181.md` 9).

Task 195 measured the first query on 26 September, before task 212's warm-up existed, and found Varka slower than stock Spark at every rung: a new shape's kernel was never compiled over a hundred thousand rows. Task 212 then compiled new kernels in the background, on by default, and `VarkaColdStartBenchmark` gained the warm-up's arms. From that committed file (laptop, 100 000 Arrow-cached rows, best of five):

| entries | stock Spark, first run | Varka with warm-up, first run | stock Spark, second run | Varka, once compiled |
|---|---|---|---|---|
| 16 | 115 ms | 169 ms | 52 ms | 26 ms |
| 54 | 448 ms | 342 ms | 427 ms | 27 ms |
| 100 | 867 ms | 619 ms | 812 ms | 37 ms |

So bound 4 is restated: below the cliff Varka's first queries of a new shape cost about half again more; past it they already cost less; the cost is paid once per shape, since the shape cache keys a kernel by its tree and not its literals; and the warm-up's verdict takes about two seconds at 16 entries and twelve to thirteen at a hundred. The section gives 3.8 its paragraph in the post's voice, and records what is still owed: these are laptop numbers, and the post's numbers come from GitHub-hosted runners, so the benchmark runs there before publication (and will include task 221's warm-up fix, apache#467).

The milestone row notes the step.

### Why are the changes needed?

The outline listed the first-query cost as the one measurement standing between it and the draft; the measurement existed and its reading had changed.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

`dev/varka_quote_check.py` (every number traces to the committed results file) and the Varka pre-commit checks pass. Documentation only.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants