Repository navigation
Conversation
|
Can one of the admins verify this patch? |
|
I don't see how the build failure is related to the commit. How can I get the build re-triggered ? |
|
To retrigger the build, you write: Jenkins, retest this please. I think anything with "retest" does it. Not sure if you have to say "please" but manners never hurt! |
|
I actually don't think this particular PR ever was tested with Jenkins (?). Jenkins, test this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
My understanding was that a successful run of automated jenkins test would remove the "travis CI" build error from the PR. Looks like that is not the case. How is the "Travis CI" build different from the automated Jenkins test run ? How do I go about fixing/getting-rid of the "Travis CI" build error from the PR so that it can be merged if/when we decide to merge it ? |
|
@kalpit Don't worry about Travis at the moment, it's not the official test. Jenkins's test succeeded as you can see. |
|
Ok. I won't monitor the PR then. You can merge it when the time is right. Thanks. |
|
Jenkins, retest this please. Seems reasonable to bump this up. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15435/ |
|
Jenkins, retest this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Thanks, I've merged this. |
https://github.com/sbt/sbt-assembly/blob/master/README.md Author: Kalpit Shah <[email protected]> Closes apache#555 from kalpit/upgrade/sbtassembly and squashes the following commits: 1fa7324 [Kalpit Shah] sbt 0.13.X should be using sbt-assembly 0.11.X
https://github.com/sbt/sbt-assembly/blob/master/README.md Author: Kalpit Shah <[email protected]> Closes apache#555 from kalpit/upgrade/sbtassembly and squashes the following commits: 1fa7324 [Kalpit Shah] sbt 0.13.X should be using sbt-assembly 0.11.X
The default pod network cidr is 192.168.0.0/16, it perhaps conflict with the node ip, there are two ways to fix this, change the cidr or change the network add on, we choose the second one here. Related-Bug: theopenlab/openlab#298
### What changes were proposed in this pull request? `VarkaEmitCostAuditSuite` fails on master. apache#552 regenerated `sql/varka/emit_cost_audit.json` before apache#547 merged, and apache#547's review changed what the emitter builds. Its use count follows the walk's rule and leaves fewer dead slots, which removes enough bytes from long composition 5 of the audit's wide compositions that its one byte regroup with the prediction off no longer fires. The two PRs merged textually, so master's file still has the old count. This regenerates the file on master: one count moves from 1 to 0, and that shape's rebuild list loses the regroup. `PLAN_TASK_236.md` 2.1 notes that the shapes rebuilt on bytes went from 2 to 1; every other figure there stands. ### Why are the changes needed? Master's own suite fails without it, and so would every Varka PR's CI. ### Does this PR introduce _any_ user-facing change? No. A regenerated test oracle and a note in a plan. ### How was this patch tested? `VarkaEmitCostAuditSuite` passes against the regenerated file on master; `dev/varka_quote_check.py` reports zero orphans. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5)
4 participants
https://github.com/sbt/sbt-assembly/blob/master/README.md