Repository navigation
[ty] Add support for PEP 750 t-strings - #20085
Merged
Merged
Conversation
dylwil3
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
August 25, 2025 17:44
dylwil3
commented
Aug 25, 2025
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
dylwil3
commented
Aug 25, 2025
Comment on lines
5193
to
+5117
| fn known_class_roundtrip_from_str() { | ||
| let db = setup_db(); | ||
| let mut db = setup_db(); | ||
| Program::get(&db) | ||
| .set_python_version_with_source(&mut db) | ||
| .to(PythonVersionWithSource { | ||
| version: PythonVersion::latest_preview(), | ||
| source: PythonVersionSource::default(), | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
Let me know if you'd like me to handle this differently, and/or add an assertion to remind us to modify this once the latest supported version is Python 3.14
Contributor
|
dylwil3
changed the title
ty] Add support for PEP 750 t-strings 
AlexWaygood
approved these changes
Aug 25, 2025
dylwil3
enabled auto-merge (squash)
August 25, 2025 18:39
dylwil3
disabled auto-merge
August 25, 2025 18:39
dylwil3
enabled auto-merge (squash)
August 25, 2025 18:46
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
This PR attempts to adds support for inferring`string.templatelib.Template` for t-string literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to add support for inferring
string.templatelib.Templatefor t-string literals.First PR of this kind so apologies in advance if I've made a mess of things! Also this is low priority so feel free to ignore.
Diff is relatively small but feel free to review commit-by-commit if it's more convenient.
Also tested LSP:
