Skip to content

force freezing version to use log and skip odict when builtin in use - #5

Merged
astrofrog merged 4 commits into
astrofrog:python-3xfrom
eteq:python-3x
Oct 21, 2011
Merged

astrofrog merged 4 commits into
astrofrog:python-3xfrom
eteq:python-3x

Conversation

@eteq

@eteq eteq commented Oct 20, 2011

Copy link
Copy Markdown

This does the two things I mentioned in the astropy repo pull request - uses the distutils.log.info mechanism with distutils.log.set_threshold to make it actually be visible, and skips all the odict tests for python versions >=2.7 (for which OrderedDict is in teh standardlib, and the astropy odict just gives the standard object).

Note that I have do a little check to see if '-q' or '--quiet' is at the command line because that should supress messages in setup... but because the version number freeze comes before setup.py, I just use the sort of dumb way of looking directly for the arguments.

Comment thread astropy/utils/tests/test_odict.py Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be::

from ..tests.helper import pytest

or something similar (which uses the real pytest if installed, or the bundled one if not). You may have to tweak the relative path.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're so close - it needed three dots instead of two :)

@astrofrog

Copy link
Copy Markdown
Owner

Thanks!

astrofrog added a commit that referenced this pull request Oct 21, 2011
force freezing version to use log and skip odict when builtin in use
@astrofrog
astrofrog merged commit e1d83d7 into astrofrog:python-3x Oct 21, 2011
astrofrog pushed a commit that referenced this pull request Dec 7, 2012
astrofrog pushed a commit that referenced this pull request Oct 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants