Skip to content

pyephem dependency #111

Closed
Closed

Description

@cdeil

@eteq @bmorris3 – What's the plan / timeline for getting rid of the pyephem dependency in astroplan?

If it's likely ~ a year or longer, I'd suggest to change the conda package and put pyephem as a dependency, so that users automatically get the full functionality.

Activity

  1. added this to the 0.2 release milestone on Sep 11, 2015
  2. bmorris3 commented on Sep 11, 2015

    @bmorris3
    Contributor

    @eteq said (on Slack) he's working on an astropy fix that will make the
    PyEphem workaround unnecessary. @eteq would it be feasible that the fix
    might be ready by astroplan v0.2?

    On Friday, September 11, 2015, Christoph Deil [email protected]
    wrote:

    Assigned #111 #111 to
    @bmorris3 https://github.com/bmorris3.

    —
    Reply to this email directly or view it on GitHub
    #111 (comment).

    Brett Morris
    Graduate Student
    Astronomy and Astrobiology
    University of Washington
    http://brettmorr.is

  3. bmorris3 commented on Oct 15, 2015

    @bmorris3
    Contributor

    @eteq - we're nearing .Astronomy (two weeks way), any chance the AltAz fixes will be done by then so I can do a bunch of PRs to remove PyEphem from astroplan once and for all?

  4. bmorris3 commented on Oct 26, 2015

    @bmorris3
    Contributor

    @eteq If I were to remove the PyEphem dependencies, update the moon methods, and change the requirements by the end of the week to astrpy v1.0.6, would you be able to review the PR? It shouldn't be a long PR and the tests don't have to change. Also -- is that a good idea?

    I would also be able to implement moon_rise_time ❗

  5. bmorris3 commented on Aug 4, 2016

    @bmorris3
    Contributor

    Closed by #167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions