Repository navigation
discretize_model should work or throw an error for non-model callable input #2274
Description
Currently discretize_model silently fails (i.e. returns None) for a non-model callable as input:
>>> from astropy.convolution import discretize_model
>>> def my_model(x):
... return 42 * x
>>> array = discretize_model(my_model, x_range=(-3, 3))
>>> print(array)
None
One option would be to remove all the isinstance checks and slightly change the API (add an argument callable_n_dim=1) to be able to process any callable as input.
Another option would be to fix the isinstance checking to throw a TypeError if something other than a Parametric1DModel or a Parametric2DModel is passed.
Activity
cdeil commentedon Apr 30, 2014
@astrofrog @adonath What do you think would be a good fix for this bug?
(I've mentioned two options above, but there might be better ones?)
eteq commentedon May 5, 2014
@cdeil - I don't understand why
callable_n_dimis necessary in your example. Can't it just be inferred from whether or noty_rangeis present? (E.g.,y_range == Noneimplies 1D, otherwise 2D). In that case, I'd say its appropriate only to check that it's consistent if aFittableModelis present. So that would give the bahvior that, ify_range==Noneand it's aFittable2DModel, ory_range != Noneand its aFittable1DModel, an error should be given. But if it's a callable, usey_rangebeing None or not to infer the dimension.Fixed astropy#2274
Fixed astropy#2274
Fixed astropy#2274
Fixed astropy#2274
Fixed astropy#2274
Merge pull request #3220 from adonath/fix_convolution_issues
embray commentedon Dec 19, 2014
Fixed by #3220; thanks @adonath !