Skip to content

Upcoming leapsecond updates for older releases #3791

Closed

Description

@dlakaplan

There will be a new leap second on 2015-06-30. How will astropy deal with this? If I understand correctly, for new releases/pulls from git the newer IERS tables will be included. Is that correct? If so, any idea when (the IERS A file already includes the new leap second)?

More importantly, is there a way to properly update those files for older releases? Some people hesitate to upgrade critical installations (used by large processing efforts) but we don't want times to get out of sync. I see:

http://astropy.readthedocs.org/en/latest/time/#transformation-offsets

But that doesn't seem to store the updated info. Is it as simple as (for IERS B):

from astropy.utils.iers import IERS_B, IERS_B_URL
from astropy.utils.data import download_file
import os
iers_b_file = download_file(IERS_B_URL, cache=True)
os.rename(iers_b_file, astropy.utils.iers.IERS_B_FILE)

(see also #3275) executed with appropriate permissions? Can this be included as an appropriately bundled script?

Activity

  1. dlakaplan commented on May 21, 2015

    @dlakaplan
    Author

    Sorry, I meant:

    from astropy.utils.iers import IERS_B, IERS_B_URL, IERS_B_FILE
    from astropy.utils.data import download_file
    import os
    iers_b_file = download_file(IERS_B_URL, cache=True)
    os.rename(iers_b_file, IERS_B_FILE)
    
  2. mhvk commented on May 21, 2015

    @mhvk
    Contributor

    @dlakaplan - note that the IERS tables only affect UTC->UT1, not the leap seconds in, e.g., UTC->TAI. It does mean that both IERS and ERFA(?) needs to be updated. CC @taldcroft. And cc @eteq as the one who thought he could make a nice automatic script. Also see #3275.

  3. taldcroft commented on May 21, 2015

    @taldcroft
    Member

    The current master for the ERFA project has the leap second in it (thanks to @timj with liberfa/erfa#26).

    So we need:

    • A release of ERFA (v1.2?)
    • Incorporate the ERFA 1.2 into astropy.
    • A bugfix release of astropy.

    Now here is where it gets interesting. We want to get this into an astropy release soon, and definitely well before June 30. That means a bugfix / patch release. I think that the update to ERFA can be mostly classified (at least for our purposes) as a bugfix release, though it does appear some "duplicate" functions were removed. I haven't dug into exactly what that means.

    @eteq @timj - thoughts?

    As @dlakaplan notes it would be nice to backport the leap second update to at least 0.4.x. Can that be done simply by a change to dat.c like here?

  4. taldcroft commented on May 21, 2015

    @taldcroft
    Member

    Oops, I meant to cc @embray on this for comment about a bugfix release.

  5. timj commented on May 21, 2015

    @timj
    Contributor

    I think just copying the dat.c to an older release is all that is needed. That file doesn't care about any other part of ERFA. Regarding the duplication -- I think that was because a header file had declared the same function twice.

  6. embray commented on May 22, 2015

    @embray
    Member

    I think in the past I've said that if we want to release leapsecond updates we can do it as patch releases. I agree it should be backported to 0.4.x as well.

  7. added this to the v1.0.3 milestone on May 22, 2015
  8. eteq commented on May 28, 2015

    @eteq
    Member

    I think we could possibly have considered this closed by #3794, but definitely #3802 should do the job.

  9. embray commented on May 29, 2015

    @embray
    Member

    Yup, this is ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions