Skip to content

Update local ERFA to include 2015-Jun-30 leap second - #3794

Merged
taldcroft merged 3 commits into
astropy:masterfrom
taldcroft:time-leapsec
May 27, 2015
Merged

taldcroft merged 3 commits into
astropy:masterfrom
taldcroft:time-leapsec

Conversation

@taldcroft

Copy link
Copy Markdown
Member

This is a minimal patch to make astropy.time aware of the leap second on 2015-Jun-30. This simply copies liberfa/erfa/src/dat.c to cextern/erfa/dat.c and replicates the change to dat.c in liberfa/erfa#26.

The other option is to make a new release of ERFA and then include that new release in astropy. The footprint would be much larger and the scope of changes would be much more than just the leap second.

This is a bit late in coming and we should not wait too long to get something merged and released.

@mhvk

mhvk commented May 23, 2015

Copy link
Copy Markdown
Contributor

@taldcroft - looks good, like the updated test. I restarted the one travis job that failed (seemed to have timed out on something).

@taldcroft

Copy link
Copy Markdown
Member Author

It looks like the appveyor build is stuck permanently. Can anyone restart this?

@mwcraig

mwcraig commented May 25, 2015

Copy link
Copy Markdown
Member

@taldcroft -- several days of astropy appveyor tests are stalled....contacting appveyor support.

cc @astrofrog

@embray

embray commented May 26, 2015

Copy link
Copy Markdown
Member

Should we be making a release once this is merged?

@embray

embray commented May 26, 2015

Copy link
Copy Markdown
Member

Changelog nag (this seems like an important one too)

@taldcroft

Copy link
Copy Markdown
Member Author

@embray - yes, a release would be good.

taldcroft added a commit that referenced this pull request May 27, 2015
Update local ERFA to include 2015-Jun-30 leap second
@taldcroft
taldcroft merged commit f9c4599 into astropy:master May 27, 2015
@taldcroft
taldcroft deleted the time-leapsec branch May 27, 2015 01:50
@taldcroft

Copy link
Copy Markdown
Member Author

From @sergiopasra :

For package managers that use a system-installed erfa, we need a new release of the library
liberfa/erfa#28

It seems maybe we have a problem here with the (quick) local patch. The issue is that I don't know for sure if ERFA 1.2 is strictly back-compatible and qualifies as a bug fix. Then there is the organizational issue of getting out the release.

@eteq

eteq commented May 28, 2015

Copy link
Copy Markdown
Member

@taldcroft - I'm almost sure 1.2 is backwards-compatible. (Technically it isn't "1.2" if it isn't, anyway...) Will try to get a release out ASAP, and then that can be incorporated into astropy for sanity's sake.

@embray

embray commented May 28, 2015

Copy link
Copy Markdown
Member

Well, who's determining the version numbers for ERFA? Are they just mirroring the SOFA versions? In that case there's no guarantee they're using anything resembling semantic versioning :)

@eteq

eteq commented May 28, 2015

Copy link
Copy Markdown
Member

@embray - we are: see https://github.com/liberfa/erfa/blob/master/RELEASE.rst#version-numbering where this is all laid out. the SOFA scheme really makes no sense in this regard so we're keeping strictly to semantic + the standard unix-y shared library scheme.

@eteq

eteq commented May 28, 2015

Copy link
Copy Markdown
Member

@taldcroft - see #3802, which updates to the just-release 1.2.0 . That should make everything happy again.

taldcroft added a commit that referenced this pull request May 28, 2015
Update local ERFA to include 2015-Jun-30 leap second
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants