ascii.latex.AASTex: don't include new line characters after last row of data

Very minor issue: writing a table in AASTex (deluxetable) format includes new line characters at the end of each line, including the last one. This results in a blank line at the end of each table. The last row of a table before "\enddata" should not include the "\" characters.

Example:

from astropy.io import ascii
from astropy.table import Table
import sys    
t = Table([[1,2],[1.234e9,2.34e-12]], names = ('a','b'))
ascii.write(t,sys.stdout,Writer=ascii.latex.AASTex)

Result:

\begin{deluxetable}{cc}
 \tablehead{\colhead{a} & \colhead{b}}
\startdata
1 & 1234000000.0 \\
2 & 2.34e-12 \\
\enddata
\end{deluxetable}

Which looks like:

But if you got rid of the "\" after 2.34e-12, you'd get:

Confirmed, and definitely worth fixing.

@hamogu

I personally think this is an upstream issue in LaTeX, but I agree we can fix this here. 😄

Here is a brutal hack that does the trick. Can you think of a better way @hamogu ?

diff --git a/astropy/io/ascii/latex.py b/astropy/io/ascii/latex.py
index 187cf99..c05e986 100644
--- a/astropy/io/ascii/latex.py
+++ b/astropy/io/ascii/latex.py
@@ -385,6 +385,7 @@ class AASTexData(LatexData):
     def write(self, lines):
         lines.append(self.data_start)
         core.BaseData.write(self, lines)
+        lines[-1] = lines[-1][:-2]  # strip off final '\\' of last data line
         lines.append(self.data_end)
         add_dictval_to_list(self.latex, 'tablefoot', lines)
         lines.append(r'\end{' + self.latex['tabletype'] + r'}')

Oh, does plain LaTeX have the same problem? The table output has the same final trailing \\ but I don't know if this is a problem for plain tables.

@taldcroft

@taldcroft : I think that's fine. This is a very specialized reader/writer where we can do these "ad-hoc" solutions.
Do you want to convert this into a PR? I would ask you to add a comment to the code above the line that you added that explains what it does. It's not immediately obvious for future maintainers.

Also, I just checked regular LaTeX. That does not have this problem; it seems to be specific to ApJ's deluxetable package.

@jrka

@jrka - do you want to take a crack at this? In any case I'm leaving this open as low-hanging fruit for the upcoming astropy sprint at scipy 2015.

@taldcroft

@taldcroft , since scipy is just next week I'll keep it on the back burner for now. But if no one gets to it, I will do so!

If this issue isn't fixed, can I work on this issue?

@shwetamore1295

@shwetamore1295 - go for it!

Please check #4561.

Added changelog entry. Fixes astropy#3888.

Replaced slicing by regular expression for more robust matching. Fixes …

Added changelog entry. Fixes astropy#3888.

Replaced slicing by regular expression for more robust matching. Fixes …

Navigation Menu

Repository navigation

ascii.latex.AASTex: don't include new line characters after last row of data #3888

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

ascii.latex.AASTex: don't include new line characters after last row of data #3888

Description

Activity

embray commented on Jun 26, 2015

taldcroft commented on Jun 30, 2015

taldcroft commented on Jun 30, 2015

hamogu commented on Jun 30, 2015

taldcroft commented on Jun 30, 2015

jrka commented on Jun 30, 2015

shwetamore1295 commented on Jan 26, 2016

taldcroft commented on Jan 26, 2016

anchitjain1234 commented on Feb 4, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions