Repository navigation
subprocess.check_output doesn't exist #42
Description
In line 204 of setup_helpers.py:
output = subprocess.check_output(c.compiler + ['--version'])
leads to AttributeError: 'module' object has no attribute 'check_output'.
Is this subprocess.check_call()?
Metadata
Metadata
Assignees
Labels
No labels
Activity
mdboom commentedon Nov 2, 2011
Ah. I hadn't noticed this is Python 2.7 only. I will replace it with something that works on 2.6 as well. Expect a pull request shortly.
Don't use subprocess.check_output -- it is not available on Python 2.6.
eteq commentedon Nov 2, 2011
@mdboom - Should this issue be closed (that is, did the pull request fix it)? I checked earlier, and it appears that if you put "closes #42" or "fixes #42" in the merge commit message (for the pull requests), it will close the issue, even if you don't reference it directly in the actual commits that are part of the pull request.
mdboom commentedon Nov 3, 2011
Interesting. I did put "Closes #42" in the commit, but it didn't seem to close this. Anyway, yes, I consider it resolved.
Don't use subprocess.check_output -- it is not available on Python 2.6.
Fixes Issue astropy#42 seperates the table based on provisional column