Repository navigation
Suggestion: remove bundled py.test version #5509
Description
Activity
👍 on the idea, but we have to be super careful with the removal as per policy most of the affiliates are using the bundled version.
Are there any changes you make to pytest? If not the only change would be a upgrade of pytest version?
I think this is a good idea to remove the bundled
pytestversion from Astropy core.Packaging has improved a lot, and having it separate will allow affiliated packages to do the pytest 2 -> 3 transition at their own pace.
What's needed here to make progress?
Further discussion on astropy-dev if there's consensus first?Or if everyone agrees it's a better long-term solution, maybe even a small docs change and "what's new" entry for 1.3 saying that this is the plan and affiliated packages are encouraged to change their setup / imports is possible to get this going?
I would say to move forward we need to check for objections on the list.
(another package we might want to consider unbundling is six - it's in the conda defaults channel and is also trivial as a pip dependency)
What about not worrying much about six in the next 6 month, and then we can remove it for good for v3.0 when we drop py2 support?
wooo, Python 3 only wooo
Until Python 4 anyway 😛
I think the first step should actually be for us to stop using the bundled version internally, but keeping it there with a deprecation warning. Then in 2.0 we don't use the bundled py.test, and in the following version we remove it altogether.
(I'm working on that)
Once #5277 is fixed, we should seriously consider no longer vendoring py.test with Astropy. As of py.test 3.x, the
--genscriptoption which we use to make the bundled version is no longer supported, so in the long term we will be stuck with the version we have. This may then cause incompatibilities in future with plugins, and future Python versions.