Repository navigation
script 'fitscheck' not deleting CHECKSUM and DATASUM keywords #5874
Description
Activity
- changed the title
[-]script `fitscheck` not deleting `CHECKSUM` and `DATASUM` keywords[/-][+]script 'fitscheck' not deleting CHECKSUM and DATASUM keywords[/+]on Mar 11, 2017 After some digging here's what I think the issue is :-
In order for the
CHECKSUMandDATASUMkeywords to be removed, the checksum kwarg should be passed asHDUList.writeto(checksum='remove')notFalseas is done by theFitscheckscript.
(https://github.com/astropy/astropy/blob/master/astropy/io/fits/scripts/fitscheck.py#L112)
Since this callsbase._prewriteto()->base._update_checksum()which deletes only whenremoveis the kwarg.Now, as for the error raised, it is raised only when one uses
-k noneoption as I have highlighted in the issue. This is because in (https://github.com/astropy/astropy/blob/master/astropy/io/fits/scripts/fitscheck.py#L135)
There we open the fits file, the call stack terminates atbase._readfrom_internal()which is supposed to call_verify checksum_datasum(which setshdu._checksum) but doesn't because the script option "none" sets the checksum kwarg to False. Check the reference below.
Reference
(https://github.com/astropy/astropy/blob/master/astropy/io/fits/hdu/base.py#L460)- added a commit that references this issue
on Mar 12, 2017 I would say bug fix should be a separate PR from adding tests because they are milestoned differently, but looks like you already added the fix into the testing PR.
Reacted by Michael Seifert and Simon Conseil- added a commit that references this issue
on Mar 14, 2017
Astropy v2.0
While working on #5858 I am seeing this particular behavior for
fitscheck:-fitscheck -v test0.fits(A test file included inastropy/io/fits/tests/data/) which works finefitscheck -v --force --write test0.fits(write correct checksums and datasums for each HDU in file)Fine too. It first warns then
updatesfitscheck -v --checksum none --write(seeing call trace manually)This comes from (https://github.com/astropy/astropy/blob/master/astropy/io/fits/scripts/fitscheck.py#L143)
As a matter of fact now that I've added checksums above, it verifies them successfully when I run
fitscheck -v test0.fits:-Is there something I'm missing? Or should I go ahead try to correct this.
Edit : This
AttributeErroris raised whenever one uses-k noneor--checksum none