Repository navigation
Update GaussianAbsorption1D #6195
Description
Activity
I just blasted
astropy-devmailing list about this. I propose we just deprecate it if we don't hear strong objection by Friday. AFAIK no one is using it and I didn't find it terribly useful with composite model and unit support now.Reacted by Thomas Robitaille"I'll be back!"
Reacted by Thomas Robitaille👍 to deprecate + remove!
Reacted by P. L. LimHaving a quick github search, it seems that a few people are using it, most notably https://github.com/spacetelescope/specview
However they should get plenty of warning with the deprecation, so 👍 to go for it."specview" is defunct, so don't worry about it. 😄
Reacted by Brigitta SipőczIt is a common use case to fit absorption lines, but as the linked discussion above points out this can be done as
constant - absorption model. Maybe this can be one example in the docs? It's a common use case, and the deprecation warning could even point to it.(As an aside, this issue is exactly why I have not used astropy models in any science or production code: It just changes too fast, so I have to spend too much time just to keep up with astropy changes. I hope that settles down after 2.0.)
@hamogu , Python itself changes too. You can always pin your Astropy requirement to a LTS until you have time to catch up. As discussed in the given link above,
GaussianAbsorption1Das-is cannot support units. And I did mention that you can useConst1D - Gaussian1Din the deprecation message. Hope this clarifies the issue.
The GaussianAbsorption1D needs to be updated in one of two ways:
or
See https://github.com/astropy/astropy/pull/6183/files#r121763241 for some discussion.