Repository navigation
Update GaussianAbsorption1D #6195
Description
The GaussianAbsorption1D needs to be updated in one of two ways:
- Either the continuum level should be made a parameter so that the model can be used with units
or
- The model should be deprecated if we think no one is using it
See https://github.com/astropy/astropy/pull/6183/files#r121763241 for some discussion.
Activity
pllim commentedon Jun 14, 2017
I just blasted
astropy-devmailing list about this. I propose we just deprecate it if we don't hear strong objection by Friday. AFAIK no one is using it and I didn't find it terribly useful with composite model and unit support now.astrofrog commentedon Jun 14, 2017
@pllim is... THE DEPRECATOR 😆
pllim commentedon Jun 14, 2017
"I'll be back!"
adrn commentedon Jun 14, 2017
👍 to deprecate + remove!
bsipocz commentedon Jun 14, 2017
Having a quick github search, it seems that a few people are using it, most notably https://github.com/spacetelescope/specview
However they should get plenty of warning with the deprecation, so 👍 to go for it.
pllim commentedon Jun 14, 2017
"specview" is defunct, so don't worry about it. 😄
hamogu commentedon Jun 14, 2017
It is a common use case to fit absorption lines, but as the linked discussion above points out this can be done as
constant - absorption model. Maybe this can be one example in the docs? It's a common use case, and the deprecation warning could even point to it.(As an aside, this issue is exactly why I have not used astropy models in any science or production code: It just changes too fast, so I have to spend too much time just to keep up with astropy changes. I hope that settles down after 2.0.)
pllim commentedon Jun 15, 2017
@hamogu , Python itself changes too. You can always pin your Astropy requirement to a LTS until you have time to catch up. As discussed in the given link above,
GaussianAbsorption1Das-is cannot support units. And I did mention that you can useConst1D - Gaussian1Din the deprecation message. Hope this clarifies the issue.