Skip to content

Deprecate InheritDocstrings #7167

Closed

Description

@pllim

As mentioned by @saimn in #7162 (comment) , this feature is finally implemented upstream by Sphinx. When Sphinx minversion >=1.7, InheritDocstrings can be deprecated, to be removed in a future release afterwards.

sphinx-doc/sphinx#4126
sphinx-doc/sphinx#4129
https://github.com/sphinx-doc/sphinx/blob/0fb832baa54a791bbca0be620bad47b6c69b680c/CHANGES#L1326-L1327 -- In case of missing docstring try to retrieve doc from base classes (ref: sphinx-doc/sphinx#3140)

Activity

  1. added this to the v4.0 milestone on Jun 18, 2019
  2. bsipocz commented on Jun 18, 2019

    @bsipocz
    Member

    we might be able to do this in 4.0, assuming we choose a new enough min version of sphinx to support.

  3. pllim commented on Jun 20, 2019

    @pllim
    MemberAuthor

    Looking at actual implementation at sphinx-doc/sphinx#4012 , the inheritance should "just work" without much messing around? 🤔

  4. pllim commented on Jul 18, 2019

    @pllim
    MemberAuthor
  5. changed the title [-]Deprecate (and later remove) InheritDocstrings[/-] [+]Deprecate InheritDocstrings[/+] on Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions