Skip to content

MNT: Move utils.timer to astroquery #8898

Closed

Description

@pllim

@saimn and @astrofrog has brought up that https://github.com/astropy/astropy/blob/master/astropy/utils/timer.py is only used by astroquery.vo_conesearch (used to be astropy.vo.conesearch) and nothing else in the core, and thus should be moved to astroquery.

  1. Do the move and deprecate the one in astropy.
  2. Remove it from astropy after a deprecation period.

Is Step 1 a good thing for 4.0?

Progress

Activity

  1. bsipocz commented on Jun 21, 2019

    @bsipocz
    Member

    We also need to make sure there is no wider usage out in the wild, after all the functionality is in the public API.

    If we move and deprecate then yes, 4.0 is a good time to do it.

  2. added this to the v4.0 milestone on Jul 22, 2019
  3. pllim commented on Jul 25, 2019

    @pllim
    MemberAuthor

    FWIW, a quick search on GitHub does not show that timer is used outside of conesearch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions