@pllim - let me know when you're ready for review.

@bsipocz , it is ready. Thanks! 😄

Codecov Report

Merging #1508 into master will increase coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
+ Coverage   62.44%   62.64%   +0.19%     
==========================================
  Files         176      177       +1     
  Lines       14651    14727      +76     
==========================================
+ Hits         9149     9225      +76     
  Misses       5502     5502

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fca9945...c50bbc4. Read the comment docs.

Oh, vicious cycle. master on astroquery now run into the deprecation warning already been merged upstream, but can't yet merge this due to py2.

I think we can officially declare a 🔥 situation...

Can we deal with this? I don't really understand what's going on...

@keflavich - I'm trying my best to get those warnings ignored for 0.3.10. This can otherwise be merged once we remove the python2 testing (after 0.3.10).

@bsipocz , rebased. Now it only has things strictly related to moving over utils.timer. Thanks for your patience!

Can you rebase again? This should be ready to go in now.

Done 🤞

This failure is extremely weird, and I don't understand it. The changes has been made a few days ago, and it passed all the tests since.

Oh, never mind, I see.

Thanks @pllim!