Repository navigation
Handle auto_max_age = None consistently - #10126
Merged
Merged
Conversation
4 tasks
pllim
reviewed
Apr 8, 2020
| astropy.utils | ||
| ^^^^^^^^^^^^^ | ||
|
|
||
| - Fix case where ``None`` could be used in a numerical computation. [#10126] |
Member
There was a problem hiding this comment.
The entry might be moved depending on the milestone set. FYI.
mhvk
reviewed
Apr 8, 2020
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
This looks good. One comment about the test...
mhvk
approved these changes
Apr 8, 2020
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Great, now all looks good! I think this is a bug being fixed, so logically would go to 4.0.2, so what's left would be to move the milestone. If possible, rebase & squash commits at the same time...
Member
Author
|
I moved the change log entry to 4.0.2. If that looks good, I can rebase/squash. |
mhvk
approved these changes
Apr 8, 2020
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Yes, this is the right place. Since tests just ran again, let me just merge this - not such a big deal to have a few more commits. Thanks!!
bsipocz
pushed a commit
that referenced
this pull request
Apr 13, 2020
Handle auto_max_age = None consistently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a "bare" use of
Nonein a numerical computation and ensuresthat
Noneis converted to a valid float throughout the module. See also #9479.