Repository navigation
Remove deprecated utils.timer and utils.misc.InheritDocstrings - #10281
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
In the original issues, this removal was planned for 4.2 |
This comment has been minimized.
This comment has been minimized.
Member
|
Unless that's changed, I think the usual deprecation period is two minor releases. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks for your patience, @sashank27 ! I rebased to remove conflict and added change log. I think this is ready for 4.3, but let's see what other maintainers say. |
2 tasks done
embray
approved these changes
Nov 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to remove the
utils.timerandutils.misc. InheritDocstringsmodule as they were expected to be removed after the passing of their deprecation period (i.e. after 4.0)Fixes #9024
Fixes #9050
EDIT: Close #10847