Skip to content

Fix handling of 1d table elements with single entry in fits - #10768

Merged
saimn merged 8 commits into
astropy:masterfrom
maxnoe:fix_oned_col
Oct 1, 2020
Merged

Fix handling of 1d table elements with single entry in fits#10768
saimn merged 8 commits into
astropy:masterfrom
maxnoe:fix_oned_col

Conversation

@maxnoe

@maxnoe maxnoe commented Sep 24, 2020

Copy link
Copy Markdown
Member

Description

Add test for and fix writing and reading of fits columns that contain single values in 1d columns
This pull request is to address #10765

Fixes #10765

@astropy-bot astropy-bot Bot added the io.fits label Sep 24, 2020
@pllim pllim added the Bug label Sep 24, 2020
@maxnoe
maxnoe marked this pull request as ready for review September 24, 2020 17:30
@maxnoe

maxnoe commented Sep 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

regex101 links for the new and the old regex:

new: https://regex101.com/r/jlQzyT/4
old: https://regex101.com/r/YseaAK/2

@maxnoe maxnoe mentioned this pull request Sep 25, 2020
Closed
@saimn saimn added this to the v4.0.2 milestone Sep 26, 2020
dhomeier
dhomeier requested changes Sep 26, 2020
View reviewed changes
Comment thread CHANGES.rst Outdated
@maxnoe

maxnoe commented Sep 27, 2020

Copy link
Copy Markdown
Member Author

@dhomeier The build seems to fail due to an unrelated problem to my changes. Any idea what happened there?

@dhomeier

dhomeier commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

@dhomeier The build seems to fail due to an unrelated problem to my changes. Any idea what happened there?

This appears to be caused by a simultaneous pytest update on both CI platforms, just reported in #10773.

Otherwise looks good to me; with only changelog changes could probably even have gone in with a [ci skip]!

@maxnoe

maxnoe commented Sep 27, 2020

Copy link
Copy Markdown
Member Author

Otherwise looks good to me; with only changelog changes could probably even have gone in with a [ci skip]!

Yes, sorry forgot about that

@maxnoe

maxnoe commented Sep 27, 2020

Copy link
Copy Markdown
Member Author

Thanks for getting this into the next point release

saimn
saimn requested changes Sep 27, 2020
View reviewed changes

@saimn saimn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @maxnoe, and for the regex101 links ;)
Just a few minor comments, otherwise looks good !

Comment thread astropy/io/fits/tests/test_table.py Outdated
Comment thread astropy/io/fits/tests/test_table.py
Comment thread astropy/io/fits/tests/test_table.py
@maxnoe

maxnoe commented Sep 28, 2020

Copy link
Copy Markdown
Member Author

@saimn I think I addressed all your comments, please have a look again

@maxnoe

maxnoe commented Sep 30, 2020

Copy link
Copy Markdown
Member Author

@dhomeier The tests are passing again

@saimn

saimn commented Oct 1, 2020

Copy link
Copy Markdown
Contributor

Looks good now, thanks @maxnoe !

@saimn
saimn merged commit b803ea5 into astropy:master Oct 1, 2020
@maxnoe
maxnoe deleted the fix_oned_col branch October 1, 2020 16:25
@stscijgbot-jp stscijgbot-jp mentioned this pull request Oct 2, 2020
Closed
astrofrog pushed a commit that referenced this pull request Oct 6, 2020
@saimn @astrofrog
Merge pull request #10768 from MaxNoe/fix_oned_col
e1436f2 
Fix handling of 1d table elements with single entry in fits
astrofrog pushed a commit that referenced this pull request Oct 6, 2020
@saimn @astrofrog
Merge pull request #10768 from MaxNoe/fix_oned_col
21442bc 
Fix handling of 1d table elements with single entry in fits
eteq pushed a commit to eteq/astropy that referenced this pull request Oct 12, 2020
@saimn @eteq
Merge pull request astropy#10768 from MaxNoe/fix_oned_col
aa4fb66 
Fix handling of 1d table elements with single entry in fits
@eslavich eslavich mentioned this pull request Oct 12, 2020
Merged
eteq pushed a commit that referenced this pull request Oct 13, 2020
@saimn @eteq
Merge pull request #10768 from MaxNoe/fix_oned_col
8571e68 
Fix handling of 1d table elements with single entry in fits
@saimn saimn mentioned this pull request Jan 27, 2021
Closed
@taldcroft taldcroft mentioned this pull request Feb 24, 2021
Closed
@pllim pllim mentioned this pull request Aug 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn saimn approved these changes
@dhomeier dhomeier dhomeier approved these changes

Assignees

No one assigned

Labels

Bug io.fits

Projects

None yet

Milestone

v4.0.2

Development

Successfully merging this pull request may close these issues.

Table reading/writing to/from fits does not support writing 1d arrays with a single element

4 participants

@maxnoe @dhomeier @saimn @pllim