Repository navigation
MNT: Special handling of matplotlib version checks for doc and test - #10956
Merged
Merged
Conversation
Co-authored-by: Erik M. Bray <[email protected]>
bsipocz
approved these changes
Oct 27, 2020
This was referenced Oct 27, 2020
dhomeier
reviewed
Oct 27, 2020
to avoid PY_SSIZE_T_CLEAN warning with Python 3.9 and Matplotlib 3.0 Co-authored-by: Derek Homeier <[email protected]>
pllim
force-pushed
the
mpl-special-bump
branch
from
October 27, 2020 17:23
0d75c80 to
1ee612c
Compare
Contributor
|
Haven't seen any request for changes (the conflict just arose from merging #10952); thanks for the fix! |
Member
Author
|
Looks like there is a merge commit in the PR but it is already merged so I cannot rebase it out. @bsipocz , if this is an issue, please let me know. |
Member
|
Thanks, LGTM too. |
bsipocz
pushed a commit
that referenced
this pull request
Nov 6, 2020
MNT: Special handling of matplotlib version checks for doc and test
bsipocz
pushed a commit
that referenced
this pull request
Nov 7, 2020
MNT: Special handling of matplotlib version checks for doc and test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address #10900 (comment) and fix #10954 .
matplotlib >= 3.1to build.matplotlib < 3.1.