MNT: Re-enable test_bbox_size with corrected limits in MPL 2 + 3 by dhomeier · Pull Request #11010 · astropy/astropy

dhomeier · 2020-11-09T19:40:18Z

Description

LTS version of #10952 for accommodating get_tightbbox calculation changes over Matplotlib versions from #10900 (comment) (tested under MacOS X 10.14/Python 3.8 against mpl 2.2.5, 3.0.3 and 3.3.2).

Since #11007 has turned up an additional case failing not on the upper boundaries x1, y1 but on (at least) one of the lower boundaries, not on different mpl versions but a different platform, we should wait until that issue is resolved.

pllim · 2020-11-09T19:47:44Z

Not sure why CircleCI is issuing kill signal... I will have to defer to wcsaxes maintainers to review this one.

dhomeier · 2020-11-09T21:53:29Z

The jobs seem to fail early on in the setup/build stage; I've seen similar errors on failing to install astropy_helpers or importing from a source checkout when trying to build a fresh installation for Python 3.7 or 3.9. I might just have been lucky to have still had a partial 3.8 installation around.
Are there any successful tests on the 4.0.x branch?

pllim · 2020-11-09T22:36:34Z

I think @astrofrog was going to fix the CI in 4.0.x. The CI there is currently broken.

astrofrog · 2020-11-11T06:09:04Z

The CI is fixed, so this will need rebasing

pep8speaks · 2020-11-11T15:17:50Z

Hello @dhomeier! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file astropy/visualization/wcsaxes/tests/test_misc.py:

Line 532:80: E501 line too long (89 > 79 characters)

Comment last updated at 2020-11-30 23:28:37 UTC

pllim · 2020-11-11T15:23:31Z

line too long (89 > 79 characters)

Eh... I thought we set it to 100?

pllim · 2020-11-11T15:24:23Z

CircleCI still Received "killed" signal 🤷

dhomeier · 2020-11-11T15:29:50Z

line too long (89 > 79 characters)

Eh... I thought we set it to 100?

Apparently not backported to 4.0.x.

Still the astropy_helpers-related warnings and failures

WARNING: You appear to be trying to import astropy from within a source checkout without building the extension modules first.  Attempting to (re)build extension modules: [astropy]
Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐Rebuilding extension modules ◓Rebuilding extension modules ◑Rebuilding extension modules ◒Rebuilding extension modules ◐

Received "killed" signal

and Travis also seems to hang in the "Rebuilding" stage for several minutes now without any progress.
Same what happens in my local tree with 3.7 and 3.9; with Python 3.8 it re-downloads astropy_helpers every time but at least manages to complete the build...

pllim · 2020-11-11T15:35:12Z

Something isn't right. You have a commit that doesn't belong. Ah, right. I think @astrofrog force pushed to the branch. I think you might need to open a new PR and cherry pick your commits from here.

dhomeier · 2020-11-11T15:41:46Z

I had just rebased 5 minutes ago, but then the unrelated commit still showed up here – before, I think a dozen extra commits had popped up, but maybe that was due to the force-push.

pllim · 2020-11-11T15:43:44Z

I mean, Tom R force pushed to 4.0.x itself. That can mess up a PR opened based on old 4.0.x history that no longer exists. You can reset HEAD and stuff but I think at this point, it might be easier if you pull the new 4.0.x branch and open a new PR off it.

dhomeier · 2020-11-11T15:54:00Z

At least getting rid of a880b60 allows me to build locally again (maybe I just missed that from Tom's force-push?).

pllim · 2020-11-11T15:55:15Z

At least no kill signal to CircleCI but now this:

FileNotFoundError: [Errno 2] No such file or directory: 'astropy/_erfa/pav2pv.c'

dhomeier · 2020-11-11T15:59:46Z

At least no kill signal to CircleCI but now this:
FileNotFoundError: [Errno 2] No such file or directory: 'astropy/_erfa/pav2pv.c'

Which is existing here and apparently on Travis as well; CircleCI still seems to be rebasing against something else...

dhomeier · 2020-11-11T16:10:55Z

4 seemingly unrelated failures on Travis; at least one step forward.

pllim · 2020-11-11T16:19:09Z

That is still weird though. I thought @astrofrog said the CI is fixed.

dhomeier · 2020-11-11T16:48:15Z

That is still weird though. I thought @astrofrog said the CI is fixed.

Can't identify exactly what setup steps CI is doing, but when I am reproducing first Travis's

git fetch origin +refs/pull/11010/merge
remote: Enumerating objects: 172966, done.
remote: Counting objects: 100% (171982/171982), done.
remote: Compressing objects: 100% (37507/37507), done.
remote: Total 170442 (delta 133990), reused 168698 (delta 132275), pack-reused 0
Receiving objects: 100% (170442/170442), 69.93 MiB | 211.00 KiB/s, done.
Resolving deltas: 100% (133990/133990), completed with 997 local objects.
From https://github.com/astropy/astropy
 * branch            refs/pull/11010/merge -> FETCH_HEAD

I only have __init__.py in astropy/_erfa; only after the git checkout -qf FETCH_HEAD
it is filled with the sources and templates.

astrofrog · 2020-11-11T16:51:10Z

I can try and look into the failures tomorrow, it possible that I didn't fix them all before.

bsipocz · 2020-11-25T00:10:05Z

Oh, I think I might have spotted it. circleCI on the LTS branch still runs setup.py test without running pip install -e . first, so I suppose there is a breakage of the helpers auto building erfa.

mhvk · 2020-11-25T00:32:18Z

Let me know if you think I can help - am happy to pull a branch or so and test locally.

bsipocz · 2020-11-25T00:42:39Z

Thank you @mhvk! I'm testing adding the install step in #11081, if that's not working then I would very much appreciate the help as I cannot yet reproduce the issue locally.
Pulling the current 4.0.x should be good rather than pulling this PR, as all yet open ones will likely be pushed to the next bugfix milestone.

bsipocz · 2020-11-25T01:11:18Z

🎉 - issue is solved, with some git magic @dhomeier suggested above. I don't fully see why it does the trick, but given it only affects the LTS, the "works for now"™️ is good enough for me.

However, there are a few failures.

Once it's all sorted out, I would suggest to rebase this PR as I made a bunch of small fixes to some of the backports and that messed up your base branch.

dhomeier · 2020-11-26T08:49:23Z

Can't make much sense of the first two jobs – both seem to point to the same run at
https://dev.azure.com/astropy-project/astropy/_build/results?buildId=734&view=logs&j=c2b8a904-e0f7-561c-1e4b-39d03ea0ca6d&t=3920ad07-c646-5ad5-098b-f876f3a81da4&l=1160

@bsipocz – manually triggered a rerun some days later, that seems to have done it, but no idea about the original issue.

pllim

Seems to have picked up an unrelated commit.

dhomeier · 2020-11-30T22:53:37Z

Seems to have picked up an unrelated commit.

That popped up after rebasing onto v4.0.x. I could try to rebase again, other wise no idea how to get rid of it.

pllim · 2020-11-30T22:55:43Z

Yeah, I guess you could try... 🤞 😬 🤞

dhomeier · 2020-11-30T22:56:56Z

Hasn't changed anything locally, HEAD is still directly on top of d69adc1...

pllim · 2020-11-30T22:59:19Z

Looks like the branch was force-pushed again, so you need to do that thing you did to fix things after that other force-push.

dhomeier · 2020-11-30T23:19:44Z

I've rebased about 5 times now, v4.0.x locally has its HEAD at ddf87c3, but the rebase branch still has d69adc1 on top of that. #10970 shows up as merged about 10 different times by @bsipocz, @taldcroft and myself (but seemingly all into this branch???) ; I'll be damned if I understand what is going on there!

…=2.6.1

dhomeier · 2020-11-30T23:30:14Z

At least
git rebase --onto fix-bbox-mpl2~3 fix-bbox-mpl2~1 fix-bbox-mpl2
was able to exterminate it.

bsipocz · 2020-11-30T23:53:00Z

@dhomeier - GitHub keeps the references on all backports, even the ones that are amended. It was a bit of a back and forth...

dhomeier · 2020-12-01T00:02:06Z

Must have picked up the branch at the wrong point in time then, I guess.

At least the output from the failed win_x runs is now accessible; cache integrity problems seem unrelated.

dhomeier · 2020-12-01T14:32:30Z

Stupid question: can I mark a change request as addressed other than dismissing it?

mhvk · 2020-12-01T14:51:43Z

Stupid question: can I mark a change request as addressed other than dismissing it?

Usually the reviewer will do that - so a gentle ping to @pllim.

Addressed

pllim · 2020-12-01T15:10:30Z

-    assert np.allclose(ax_bbox.y1, 432)
+
+    # Enforce strict test only with reference Freetype version
+    if atol < 0.1 and not FREETYPE_261:


Instead of running it twice with different atol, why not run it once but set the atol according to FREETYPE_261?

Yes, as noted in #11022 (comment) there are multiple redundant testing levels now that may not all be needed. Same perhaps for testing the other case as xfail rather than skipping it – I think yet other Freetype versions might fail on the stricter tolerance, but don't necessarily need to.
From a practical pov ~0.2 pt accuracy would probably be plenty for all purposes, but otoh for known mpl+ft versions we obviously can expect more precise results.
For consistency with #11022/v4.3 I'd probably leave it as is, but in the interest of keeping testing load low this can well do with a single run.

pllim · 2020-12-01T15:11:01Z

Thanks for the ping. I dismissed my change request but still have a question (see above).

pllim

Being consistent is good, I agree. Merging this as-is then. Thanks!

dhomeier · 2020-12-01T16:11:44Z

Thanks for all the repair work on the branch!

dhomeier added testing no-changelog-entry-needed visualization.wcsaxes labels Nov 9, 2020

dhomeier added this to the v4.0.4 milestone Nov 9, 2020

dhomeier requested review from Cadair and pllim November 9, 2020 19:40

dhomeier mentioned this pull request Nov 9, 2020

[4.2rc1] test_bbox_size failure with Python 3.8/3.9 #11007

Closed

pllim requested a review from astrofrog November 9, 2020 19:46

astrofrog force-pushed the v4.0.x branch from 7a4c4c6 to e0603f5 Compare November 10, 2020 11:15

dhomeier force-pushed the fix-bbox-mpl2 branch from 5fa3d94 to 270acfb Compare November 11, 2020 15:17

dhomeier force-pushed the fix-bbox-mpl2 branch from 270acfb to 9d55463 Compare November 11, 2020 15:53

pllim mentioned this pull request Nov 11, 2020

MNT: Re-enable test_bbox_size with corrected limits in MPL 2 + 3 #11029

Closed

bsipocz force-pushed the v4.0.x branch from 73f10ce to aaeb26e Compare November 25, 2020 00:27

bsipocz force-pushed the v4.0.x branch from 6656812 to b820d1e Compare November 25, 2020 02:16

bsipocz modified the milestones: v4.0.4, v4.0.5 Nov 25, 2020

dhomeier force-pushed the fix-bbox-mpl2 branch from 9d55463 to d94dd82 Compare November 26, 2020 02:13

pllim previously requested changes Nov 30, 2020

View reviewed changes

TST: test for bbox_size limits in MPL 2+3, relaxed atol for Freetype!…

739de05

…=2.6.1

dhomeier force-pushed the fix-bbox-mpl2 branch from d94dd82 to 739de05 Compare November 30, 2020 23:28

pllim reviewed Dec 1, 2020

View reviewed changes

pllim approved these changes Dec 1, 2020

View reviewed changes

pllim merged commit 860e836 into astropy:v4.0.x Dec 1, 2020

dhomeier deleted the fix-bbox-mpl2 branch December 7, 2020 03:34

Conversation

dhomeier commented Nov 9, 2020

Description

Uh oh!

pllim commented Nov 9, 2020

Uh oh!

dhomeier commented Nov 9, 2020

Uh oh!

pllim commented Nov 9, 2020

Uh oh!

astrofrog commented Nov 11, 2020

Uh oh!

pep8speaks commented Nov 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2020-11-30 23:28:37 UTC

Uh oh!

pllim commented Nov 11, 2020

Uh oh!

pllim commented Nov 11, 2020

Uh oh!

dhomeier commented Nov 11, 2020

Uh oh!

pllim commented Nov 11, 2020

Uh oh!

dhomeier commented Nov 11, 2020

Uh oh!

pllim commented Nov 11, 2020

Uh oh!

dhomeier commented Nov 11, 2020

Uh oh!

pllim commented Nov 11, 2020

Uh oh!

dhomeier commented Nov 11, 2020

Uh oh!

dhomeier commented Nov 11, 2020

Uh oh!

pllim commented Nov 11, 2020

Uh oh!

dhomeier commented Nov 11, 2020

Uh oh!

astrofrog commented Nov 11, 2020

Uh oh!

bsipocz commented Nov 25, 2020

Uh oh!

mhvk commented Nov 25, 2020

Uh oh!

bsipocz commented Nov 25, 2020

Uh oh!

bsipocz commented Nov 25, 2020

Uh oh!

dhomeier commented Nov 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pllim left a comment

Choose a reason for hiding this comment

Uh oh!

dhomeier commented Nov 30, 2020

Uh oh!

pllim commented Nov 30, 2020

Uh oh!

dhomeier commented Nov 30, 2020

Uh oh!

pllim commented Nov 30, 2020

Uh oh!

dhomeier commented Nov 30, 2020

Uh oh!

dhomeier commented Nov 30, 2020

Uh oh!

bsipocz commented Nov 30, 2020

Uh oh!

dhomeier commented Dec 1, 2020

Uh oh!

dhomeier commented Dec 1, 2020

Uh oh!

mhvk commented Dec 1, 2020

Uh oh!

pllim Dec 1, 2020

Choose a reason for hiding this comment

Uh oh!

dhomeier Dec 1, 2020

pep8speaks commented Nov 11, 2020 •

edited

Loading

dhomeier commented Nov 26, 2020 •

edited

Loading