Repository navigation
TST: Relax tolerances in test_bbox_size on Freetype version mismatch - #11022
Merged
Merged
Conversation
pllim
reviewed
Nov 10, 2020
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
I don't think I know enough about the intent of this test to review, so I'll have to defer to others.
dstansby
approved these changes
Nov 10, 2020
dstansby
left a comment
dstansby
left a comment
Contributor
There was a problem hiding this comment.
Seems like a reasonable approach to take
Contributor
Author
|
OK, thanks for reviewing – ideally @olebole would test the patch with the Debian build to confirm it actually fixes the failure, but at least it should not break anything! |
astrofrog
approved these changes
Nov 11, 2020
olebole
approved these changes
Nov 11, 2020
olebole
left a comment
olebole
left a comment
Member
There was a problem hiding this comment.
I can confirm that this patch removes the error on Debian. It now builds nicely, thank you!
Cadair
approved these changes
Nov 11, 2020
bsipocz
pushed a commit
that referenced
this pull request
Nov 23, 2020
TST: Relax tolerances in test_bbox_size on Freetype version mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checks for Freetype library Matplotlib is linked against; if this is not the reference version 2.6.1 which Matplotlib mandates for its own tests to reproduce exact comparison images, allow
test_bbox_sizeto check the bounding box extent with relaxed tolerance.Fixes #11007
This combines several possible approaches to the problem: assuming the failure on Debian is related to its Freetype 2.10, run the test once with wider tolerance and allow it to fail on the stricter comparison. We may only need one of these – assuming the test as introduced by @dstansby in #10797 should assure that the plot fits comfortably within the
tightbbox,atolof 0.1 – 0.2 pt would certainly be always acceptable.