Repository navigation
Remove metaclasses from astropy.coordinates - #11090
Merged
Merged
Conversation
mhvk
reviewed
Nov 25, 2020
adrn
force-pushed
the
coordinates/excise-metaclasses
branch
from
November 26, 2020 15:33
226f5a0 to
3d1fe42
Compare
Member
Author
|
Hm, where should I put the changelog entry for this? |
Contributor
|
Maybe "other changes"? In principle, it is just an internal refactoring with no user-facing consequences, so not sure if it is needed... |
Member
Author
|
@mhvk Ah right, I don't think I ever noticed that section 😅 |
mhvk
approved these changes
Nov 26, 2020
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Looks all good to me! I'll just merge since this does not really change anything, just make it easier to follow.
2 tasks done
Member
embray
added a commit
to embray/astropy
that referenced
this pull request
Nov 27, 2020
embray
added a commit
to embray/astropy
that referenced
this pull request
Dec 31, 2020
embray
added a commit
to embray/astropy
that referenced
this pull request
Jan 16, 2021
namurphy
pushed a commit
to namurphy/astropy
that referenced
this pull request
Feb 21, 2021
namurphy
pushed a commit
to namurphy/astropy
that referenced
this pull request
Feb 21, 2021
nstarman
pushed a commit
to nstarman/astropy
that referenced
this pull request
Feb 28, 2021
Akshat1Nar
pushed a commit
to Akshat1Nar/astropy
that referenced
this pull request
Mar 9, 2021
This was referenced Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #7144 (specifically for classes in astropy.coordinates).
I moved the logic from various metaclasses (
FrameMeta,MetaBaseRepresentation,MetaBaseDifferential) into the relevant__init_subclass__methods.Note that I wasn't able to remove
FrameMetaentirely, becauseBaseCoordinateFramestill requiresOrderedDescriptorContaineras a metaclass. But when I tried to addmetaclass=OrderedDescriptorContainerdirectly, I get a metaclass conflict error.